Skip to content

fix(window): use stored size for new floating window when persistentsize is set #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025
Merged

fix(window): use stored size for new floating window when persistentsize is set #10212

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11a0d56
fix(window): use stored size for new floating window when persistents…
yuukibarns Apr 29, 2025
614f2ad
fix: replace `std::any_of` with `std::ranges:any_of`
yuukibarns Apr 30, 2025
b28fd1a
fix: use initialClass and initialTitle when storing sizes on close
yuukibarns Apr 30, 2025
4dc30eb
fix: add `xdgTag` as a new indicator
yuukibarns May 1, 2025
f2bbc08
fix: no {}
yuukibarns May 2, 2025
33eb248
fix: format with clang-format
yuukibarns May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/layout/IHyprLayout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,18 @@ void IHyprLayout::requestFocusForWindow(PHLWINDOW pWindow) {
Vector2D IHyprLayout::predictSizeForNewWindowFloating(PHLWINDOW pWindow) { // get all rules, see if we have any size overrides.
Vector2D sizeOverride = {};
if (g_pCompositor->m_lastMonitor) {

// If `persistentsize` is set, use the stored size if available.
const bool HASPERSISTENTSIZE =
std::any_of(pWindow->m_matchedRules.begin(), pWindow->m_matchedRules.end(), [](const auto& rule) { return rule->m_ruleType == CWindowRule::RULE_PERSISTENTSIZE; });

const auto STOREDSIZE = HASPERSISTENTSIZE ? g_pConfigManager->getStoredFloatingSize(pWindow) : std::nullopt;

if (STOREDSIZE.has_value()) {
Debug::log(LOG, "using stored size {}x{} for new floating window {}::{}", STOREDSIZE->x, STOREDSIZE->y, pWindow->m_class, pWindow->m_title);
return STOREDSIZE.value();
}

for (auto const& r : g_pConfigManager->getMatchingRules(pWindow, true, true)) {
if (r->m_ruleType != CWindowRule::RULE_SIZE)
continue;
Expand Down