-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(window): use stored size for new floating window when persistentsize is set #10212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Related #10161 |
|
COMMIT 1: use stored size for new floating window May I explain the COMMIT 3. The previous implementation use class and title when storing sizes on close but I find title can be too changeable to be used as an indicator (for example title of anki's Browse page is like However, this introduce a new problem, see below. |
|
However, there are still problems to solve:
|
|
2 is too complicated to do in this MR, I say leave it. |
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Any plan on 2? |
|
not for now |
Describe your PR, what does it fix/add?
fix #9422.
When open a floating window (i.e. windowrule
floatapplied on the window), it should use the stored size ifpersistentsizeis set.Is it ready for merging, or does it need work?
I want to further improve the windowrule
persistentsizeby storing the sizes in cache or config file so that sizes can be persistent across boots, but I am a newbie in C++ and I don't know the conventional method to do this in this project, so I will wait for your kind instructions.