Skip to content

make the failure_notficiations action usable from a repo with a splice submodule #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mblaze-da merged 4 commits into from
Dec 19, 2025
+7 −2
Merged

make the failure_notficiations action usable from a repo with a splice submodule #3428

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5f7d10
make the failure_notficiations action usable from a repo with a splic…
mblaze-da Dec 18, 2025
e39b309
try to use GITHUB_ACTION_PATH to make failure_notifications work in i…
mblaze-da Dec 18, 2025
d68e1f5
install missing dependencies for a github-hosted runner
mblaze-da Dec 18, 2025
84a483b
correct GitPython dependency name
mblaze-da Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/actions/tests/failure_notifications/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ inputs:
description: "Slack channel for notifications"
required: true


runs:
using: "composite"
steps:
Expand All @@ -42,4 +41,10 @@ runs:
FAILURE_NOTIFICATIONS_URL: ${{ inputs.notifications_url }}
NOTIFICATION_SLACK_CHANNEL: ${{ inputs.slack_channel }}
shell: bash
run: ./.github/actions/scripts/notification-scripts/failure_notification.py --job_subname "${{ inputs.job_subname }}"
# on self-hosted runners all python packages are preinstalled but on github-hosted they will be missing
run: |
if [[ "${RUNNER_ENVIRONMENT}" != "self-hosted" ]]; then
Copy link
Contributor

@isegall-da isegall-da Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. we used to have an install-deps script I believe, that was called from failure_notification.sh, for this exact purpose, but we seemed to have killed it at some point. Guess this is fine too.

echo "Not a self-hosted runner. Installing required Python packages..."
python3 -m pip install GitPython requests
fi
${GITHUB_ACTION_PATH}/../../scripts/notification-scripts/failure_notification.py --job_subname "${{ inputs.job_subname }}"