make the failure_notficiations action usable from a repo with a splice submodule #3428
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e submodule [static] Signed-off-by: Mateusz Błażejewski <[email protected]>
…nternal [static] Signed-off-by: Mateusz Błażejewski <[email protected]>
[static] Signed-off-by: Mateusz Błażejewski <[email protected]>
[static] Signed-off-by: Mateusz Błażejewski <[email protected]>
isegall-da
reviewed
Dec 18, 2025
| run: ./.github/actions/scripts/notification-scripts/failure_notification.py --job_subname "${{ inputs.job_subname }}" | ||
| # on self-hosted runners all python packages are preinstalled but on github-hosted they will be missing | ||
| run: | | ||
| if [[ "${RUNNER_ENVIRONMENT}" != "self-hosted" ]]; then |
Contributor
There was a problem hiding this comment.
hmm.. we used to have an install-deps script I believe, that was called from failure_notification.sh, for this exact purpose, but we seemed to have killed it at some point. Guess this is fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to use this action from the internal repo.