[static] update TODOs following issue migration

.envrc

@@ -10,12 +10,12 @@ use_flake_subdir() {
   eval "$(nix print-dev-env --profile "$(direnv_layout_dir)/flake-profile" "path:nix" "$@")"
 }
 
-# TODO(#3876) work around for $TMPDIR is removed. #3876 to investigate more
+# TODO(DACH-NY/canton-network-node#3876) work around for $TMPDIR is removed. #3876 to investigate more
 OLD_TMPDIR=$TMPDIR
 
 use flake_subdir
 
-# TODO(#3876) work around for $TMPDIR is removed. #3876 to investigate more
+# TODO(DACH-NY/canton-network-node#3876) work around for $TMPDIR is removed. #3876 to investigate more
 export TMPDIR=$OLD_TMPDIR
 
 source_env .envrc.vars

.github/actions/nix/run_bash_command_in_nix/action.yml

@@ -77,7 +77,7 @@ runs:
 
           . .envrc.vars
 
-          # TODO(#17839): once we support cluster deployments in GHA, add cluster authentication here
+          # TODO(#615): once we support cluster deployments in GHA, add cluster authentication here
 
           MAX_RETRY=${{ inputs.cmd_retry_count }}
           n=0
@@ -112,7 +112,7 @@ runs:
               }
               cmd_wrapper && break
 
-              # TODO(#17839): support a conditional retry (cmd_retry_condition argument in CCI), used for retrying if VPN failed
+              # TODO(#615): support a conditional retry (cmd_retry_condition argument in CCI), used for retrying if VPN failed
 
               n=$[$n+1]
           done

.github/actions/scripts/backport_reminder.js

@@ -69,7 +69,7 @@ async function main(deps) {
 
   const allBranches = [
     ...(clusterBranches.map(c => flattenBranchesForCluster(c))),
-    // TODO(#16006): un-hardcode release-line-0.2 here
+    // TODO(DACH-NY/canton-network-node#16006): un-hardcode release-line-0.2 here
     ['main', 'release-line-0.2', 'release-line-0.3.0']
   ]
 

.github/actions/scripts/check-logs.sh

@@ -89,7 +89,7 @@ find_exceptions |
 
 ### Look for leaked secrets
 
-# TODO(#14876) Patch secrets in the log file
+# TODO(DACH-NY/canton-network-internal#481) Patch secrets in the log file
 sed -i 's/secret=test/secret=hidden/g' "$LOGFILE"
 
 find_secrets() {

.github/workflows/build.yml

@@ -129,7 +129,7 @@ jobs:
       runs_on: self-hosted-k8s-large
       test_names_file: 'test-full-class-names.log'
       start_canton_options: -w
-      # TODO(#10912) Investigate why things got slower
+      # TODO(DACH-NY/canton-network-node#10912) Investigate why things got slower
       parallelism: 10
       test_name: wall-clock-time
       with_gcp_creds: true

CANTON_CODE_CHANGES.md

@@ -27,7 +27,7 @@ to know which and/or what changes we'll need to upstream before the switch.
 * ``PositiveFiniteDuration` config reader and writer made public
 * `ProofOfOwnership` made public
 ## Misc
-* Added support for interface filters in ledger api ACS commands. TODO (#17403): This should be upstreamed.
+* Added support for interface filters in ledger api ACS commands. TODO (#638): This should be upstreamed.
 * Generalization of `Environment`
 * Generalization of `MetricsFactory`
 * Removed a trailing comma in many places because the CC Scala compiler doesn't like it (e.g. `.authorize(op, domain, mediator, side, key.some, )` -> `.authorize(op, domain, mediator, side, key.some)`)

apps/ans/frontend/src/__tests__/setup/config.ts

@@ -1,7 +1,7 @@
 // Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-// TODO(#7579) -- remove duplication from default config
+// TODO(#986) -- remove duplication from default config
 
 const config = {
   auth: {

apps/ans/frontend/src/context/ValidatorScanProxyContext.tsx

@@ -15,7 +15,7 @@ import {
   ResponseContext,
 } from 'scan-proxy-openapi';
 
-//TODO(#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
+//TODO(DACH-NY/canton-network-node#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
 const ValidatorScanProxyContext = React.createContext<ScanProxyApi | undefined>(undefined);
 
 export interface ValidatorScanProxyProps {

apps/ans/frontend/src/hooks/queries/usePrimaryParty.ts

@@ -1,10 +1,10 @@
 // Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
 // SPDX-License-Identifier: Apache-2.0
-// TODO(#8515) - reuse this from wallet UI
+// TODO(DACH-NY/canton-network-node#8515) - reuse this from wallet UI
 import { useUserStatus } from './useUserStatus';
 
 // A hook to fetch the primary party ID via the wallet userStatus API
-// TODO(#5176) -- consider querying the json ledger API instead to avoid having more than 1 primary party hook
+// TODO(DACH-NY/canton-network-node#5176) -- consider querying the json ledger API instead to avoid having more than 1 primary party hook
 export const usePrimaryParty = (): string | undefined => {
   const userStatusQuery = useUserStatus();
   return userStatusQuery.data?.partyId;

apps/ans/frontend/src/hooks/queries/useUserStatus.ts

@@ -1,6 +1,6 @@
 // Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
 // SPDX-License-Identifier: Apache-2.0
-// TODO(#8515) - reuse this from wallet UI
+// TODO(DACH-NY/canton-network-node#8515) - reuse this from wallet UI
 import { useUserState } from '@lfdecentralizedtrust/splice-common-frontend';
 import { useQuery, UseQueryResult } from '@tanstack/react-query';
 

apps/ans/frontend/src/hooks/scan-proxy/useGetAnsRules.ts

@@ -8,7 +8,7 @@ import { AnsRules } from '@daml.js/ans/lib/Splice/Ans/';
 
 import { useValidatorScanProxyClient } from '../../context/ValidatorScanProxyContext';
 
-//TODO(#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
+//TODO(DACH-NY/canton-network-node#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
 const useGetAnsRules = (): UseQueryResult<Contract<AnsRules>> => {
   const scanClient = useValidatorScanProxyClient();
   return useGetAnsRulesFromResponse(() => scanClient.getAnsRules({}));

apps/ans/frontend/src/hooks/scan-proxy/useLookupAnsEntryByName.ts

@@ -6,7 +6,7 @@ import { AnsEntry } from 'scan-openapi';
 
 import { useValidatorScanProxyClient } from '../../context/ValidatorScanProxyContext';
 
-//TODO(#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
+//TODO(DACH-NY/canton-network-node#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
 const useLookupAnsEntryByName = (
   name: string,
   enabled: boolean = true,

apps/ans/frontend/vite.config.mjs

@@ -22,7 +22,7 @@ export default defineConfig(({ mode }) => {
     },
     build: {
       outDir: 'build',
-      // TODO(#7672): reduce/remove this limit
+      // TODO(#854): reduce/remove this limit
       chunkSizeWarningLimit: 4800,
       commonjsOptions: {
         transformMixedEsModules: true,

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/SpliceApp.scala

@@ -13,7 +13,7 @@ import com.digitalasset.canton.CantonAppDriver
 import com.digitalasset.canton.config.ConfigErrors.CantonConfigError
 import com.digitalasset.canton.environment.EnvironmentFactory
 
-// TODO(#736): generalize. e.g. custom Cli class for Splice Node for the console
+// TODO(DACH-NY/canton-network-node#736): generalize. e.g. custom Cli class for Splice Node for the console
 object SpliceApp extends CantonAppDriver {
 
   override type Config = SpliceConfig

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/config/SpliceConfig.scala

@@ -107,7 +107,7 @@ case class SpliceConfig(
 
   override def withDefaults(defaults: DefaultPorts, edition: CantonEdition): SpliceConfig = this
 
-  // TODO(#736): we want to remove all of the configurations options below:
+  // TODO(DACH-NY/canton-network-node#736): we want to remove all of the configurations options below:
   override val participants: Map[InstanceName, ParticipantNodeConfig] = Map.empty
   override val remoteParticipants: Map[InstanceName, RemoteParticipantConfig] = Map.empty
   override val mediators: Map[InstanceName, MediatorNodeConfig] = Map.empty

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/console/LedgerApiExtensions.scala

@@ -87,7 +87,7 @@ trait LedgerApiExtensions extends AppendedClues with Matchers {
                   // We often have duplicates when merging choice contexts from multiple off-ledger APIs.
                   // Cull them here to avoid sending them twice; and because the Ledger API server
                   // currently errors out on them.
-                  // TODO(#18566): remove the note wrt the error once that's no longer the case
+                  // TODO(#560): remove the note wrt the error once that's no longer the case
                   .distinctBy(_.getContractId)
                   .map(DisclosedContract.fromJavaProto),
                 synchronizerId = synchronizerId,
@@ -187,7 +187,7 @@ trait LedgerApiExtensions extends AppendedClues with Matchers {
                 // We often have duplicates when merging choice contexts from multiple off-ledger APIs.
                 // Cull them here to avoid sending them twice; and because the Ledger API server
                 // currently errors out on them.
-                // TODO(#18566): remove the note wrt the error once that's no longer the case
+                // TODO(#560): remove the note wrt the error once that's no longer the case
                 .distinctBy(_.getContractId)
                 .map(DisclosedContract.fromJavaProto),
               synchronizerId = synchronizerId,

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/console/SpliceInstanceReference.scala

@@ -64,7 +64,7 @@ trait AppReference extends InstanceReference {
 
   override type Status = SpliceStatus
 
-  // TODO(#736): remove/cleanup all the uninteresting console commands copied from Canton.
+  // TODO(DACH-NY/canton-network-node#736): remove/cleanup all the uninteresting console commands copied from Canton.
   @Help.Summary("Health and diagnostic related commands")
   @Help.Group("Health")
   // Doesn't make sense for splice
@@ -102,7 +102,7 @@ trait HttpAppReference extends AppReference with HttpCommandRunner {
 
   def basePath: String
 
-  // TODO (#4606): Refactor so that these two methods don't need to be implemented
+  // TODO (DACH-NY/canton-network-node#4606): Refactor so that these two methods don't need to be implemented
   override def keys: KeyAdministrationGroup = noGrpcError()
 
   override def adminCommand[Result](
@@ -245,7 +245,7 @@ class ParticipantClientReference(
     override val config: RemoteParticipantConfig,
 ) extends RemoteParticipantReference(consoleEnvironment, name) {
 
-  // TODO(#5141) Consider removing this once Canton no longer explodes
+  // TODO(DACH-NY/canton-network-node#5141) Consider removing this once Canton no longer explodes
   // when uploading the same DAR twice.
   def upload_dar_unless_exists(
       path: String

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/environment/ScanApps.scala

@@ -22,7 +22,7 @@ class ScanApps(
     _loggerFactory: NamedLoggerFactory,
 )(implicit
     protected val executionContext: ExecutionContextIdlenessExecutorService
-) extends ManagedNodes[ // TODO(#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
+) extends ManagedNodes[ // TODO(DACH-NY/canton-network-node#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
       // this trait.
       ScanApp,
       ScanAppBackendConfig,

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/environment/SpliceConsoleEnvironment.scala

@@ -26,7 +26,7 @@ import org.lfdecentralizedtrust.splice.wallet.config.WalletAppClientConfig
 class SpliceConsoleEnvironment(
     override val environment: SpliceEnvironment,
     val consoleOutput: ConsoleOutput = StandardConsoleOutput,
-) extends ConsoleEnvironment // TODO(#736): Generalize this.
+) extends ConsoleEnvironment // TODO(DACH-NY/canton-network-node#736): Generalize this.
     {
 
   override type Config = SpliceConfig

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/environment/SplitwellApps.scala

@@ -22,7 +22,7 @@ class SplitwellApps(
     _loggerFactory: NamedLoggerFactory,
 )(implicit
     protected val executionContext: ExecutionContextIdlenessExecutorService
-) extends ManagedNodes[ // TODO(#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
+) extends ManagedNodes[ // TODO(DACH-NY/canton-network-node#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
       // this trait.
       SplitwellApp,
       SplitwellAppBackendConfig,

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/environment/SvApps.scala

@@ -22,7 +22,7 @@ class SvApps(
     _loggerFactory: NamedLoggerFactory,
 )(implicit
     protected val executionContext: ExecutionContextIdlenessExecutorService
-) extends ManagedNodes[ // TODO(#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
+) extends ManagedNodes[ // TODO(DACH-NY/canton-network-node#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
       // this trait.
       SvApp,
       SvAppBackendConfig,

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/environment/ValidatorApps.scala

@@ -22,7 +22,7 @@ class ValidatorApps(
     _loggerFactory: NamedLoggerFactory,
 )(implicit
     protected val executionContext: ExecutionContextIdlenessExecutorService
-) extends ManagedNodes[ // TODO(#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
+) extends ManagedNodes[ // TODO(DACH-NY/canton-network-node#736): We should remove the CantonNode/CantonNodeBootstrap type requirements from
       // this trait.
       ValidatorApp,
       ValidatorAppBackendConfig,

apps/app/src/test/resources/include/participants.conf

@@ -23,7 +23,7 @@ _participant_template {
     journal-garbage-collection-delay = 24h
   }
 
-  # TODO(#8331) Tune cache sizes
+  # TODO(DACH-NY/canton-network-node#8331) Tune cache sizes
   # from https://docs.daml.com/2.8.0/canton/usermanual/performance.html#configuration
   # tune caching configs of the ledger api server
   ledger-api {

apps/app/src/test/resources/include/svs/_sv.conf

@@ -31,7 +31,7 @@
 
     enable-expire-validator-faucet = true
 
-    # TODO(#7649) revise and/or remove
+    # TODO(DACH-NY/canton-network-node#7649) revise and/or remove
     enable-dso-delegate-replacement-trigger = true
 
     # CometBFT reconciliation is disabled by default as it would destabilize the CometBFT network by reflecting the

apps/app/src/test/resources/local-sv-node/canton-participant/canton.conf

@@ -44,7 +44,7 @@ canton {
         journal-garbage-collection-delay = 24h
       }
 
-      # TODO(#8331) Tune cache sizes
+      # TODO(DACH-NY/canton-network-node#8331) Tune cache sizes
       # from https://docs.daml.com/2.8.0/canton/usermanual/performance.html#configuration
       # tune caching configs of the ledger api server
       ledger-api {

apps/app/src/test/resources/total-supply-bigquery-import.sql

@@ -1,4 +1,4 @@
--- TODO (#18620) put this file somewhere that makes sense
+-- TODO (DACH-NY/canton-network-internal#362) put this file somewhere that makes sense
 
 -- in this example:
 -- experiment_dataset is the name of the BigQuery dataset

apps/app/src/test/resources/total-supply-bigquery.sql

@@ -1,4 +1,4 @@
--- TODO (#18620) put this file somewhere that makes sense
+-- TODO (DACH-NY/canton-network-internal#362) put this file somewhere that makes sense
 DECLARE
   as_of_record_time timestamp;
 DECLARE

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/Ans4SvsIntegrationTest.scala

@@ -19,7 +19,7 @@ class Ans4SvsIntegrationTest extends IntegrationTest with WalletTestUtil with Tr
     EnvironmentDefinition
       .simpleTopology4Svs(this.getClass.getSimpleName)
 
-  // TODO(#11927): incorporate this test into AnsIntegrationTest
+  // TODO(#787): incorporate this test into AnsIntegrationTest
   "ans" should {
     "terminated subscriptions are archived" in { implicit env =>
       setTriggersWithin[Assertion](

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/AnsIntegrationTest.scala

@@ -42,7 +42,7 @@ class AnsIntegrationTest extends IntegrationTest with WalletTestUtil with Trigge
 
   override def environmentDefinition: SpliceEnvironmentDefinition =
     EnvironmentDefinition
-      // TODO(#11927): make AnsIntegrationTest use simpleTopology4Svs
+      // TODO(#787): make AnsIntegrationTest use simpleTopology4Svs
       .simpleTopology1Sv(this.getClass.getSimpleName)
       .addConfigTransforms((_, config) =>
         updateAutomationConfig(ConfigurableApp.Sv)(

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/AppUpgradeIntegrationTest.scala

@@ -69,7 +69,7 @@ class AppUpgradeIntegrationTest
       .withInitializedNodes()
       .withTrafficTopupsEnabled
       .withManualStart
-      // TODO(#8300) Consider removing this once domain config updates are less disruptive, particularly
+      // TODO(#979) Consider removing this once domain config updates are less disruptive, particularly
       // to the tests after SVs 2 and 3 have been upgraded
       .withSequencerConnectionsFromScanDisabled()
       .addConfigTransforms((_, config) =>
@@ -252,7 +252,7 @@ class AppUpgradeIntegrationTest
             java.util.Optional.empty(),
             java.util.Optional.empty(),
           )
-          // TODO(#16139): adaptation to this test required
+          // TODO(#925): adaptation to this test required
           val upgradeAction = new ARC_AmuletRules(
             new CRARC_AddFutureAmuletConfigSchedule(
               new AmuletRules_AddFutureAmuletConfigSchedule(
@@ -652,7 +652,7 @@ object AppUpgradeIntegrationTest {
     val result = Process(
       Seq("bash", "-c", cmd),
       None,
-      // TODO(#10595): consider reading these from config files:
+      // TODO(DACH-NY/canton-network-node#10595): consider reading these from config files:
       "SV1_URL" -> "http://127.0.0.1:5114",
       "SV1_SCAN_URL" -> "http://127.0.0.1:5012",
       "SV2_SCAN_URL" -> "http://127.0.0.1:5112",

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/BftManualStartIntegrationTest.scala

@@ -31,7 +31,7 @@ class BftManualStartIntegrationTest extends IntegrationTest {
     "start with the bft sequencers" in { implicit env =>
       sv1Backend.startSync()
       sv1ScanBackend.startSync()
-      // TODO(#19670) if possible, don't require parallel start of sv app and scan
+      // TODO(#893) if possible, don't require parallel start of sv app and scan
       startAllSync(sv2Backend, sv2ScanBackend)
       startAllSync(sv3Backend, sv3ScanBackend)
       forAll(Seq(sv1Backend, sv2Backend, sv3Backend)) { sv =>

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/DecentralizedSynchronizerMigrationIntegrationTest.scala

@@ -403,7 +403,7 @@ class DecentralizedSynchronizerMigrationIntegrationTest
                   Some((migrationDumpDir(name) / "domain_migration_dump.json").path)
               )
           )(conf),
-        // TODO(#9014) Consider keeping this running and instead
+        // TODO(DACH-NY/canton-network-node#9014) Consider keeping this running and instead
         // making the test check history instead of balance once our
         // stores handle hard domain migrations properly.
         (_, conf) =>
@@ -412,10 +412,10 @@ class DecentralizedSynchronizerMigrationIntegrationTest
           )(conf),
       )
       .withManualStart
-      // TODO (#10859) remove and fix test failures
+      // TODO (#965) remove and fix test failures
       .withAmuletPrice(walletAmuletPrice)
 
-  // TODO (#10859) remove and fix test failures
+  // TODO (#965) remove and fix test failures
   override def walletAmuletPrice = SpliceUtil.damlDecimal(1.0)
 
   "migrate global domain to new nodes with downtime" in { implicit env =>

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/DisasterRecoveryIntegrationTest.scala

@@ -382,7 +382,7 @@ class DisasterRecoveryIntegrationTest
 
         // Note: the dumps contain data from the sequencers, need to get
         // the dumps before shutting down canton nodes.
-        // TODO(#11099): Once taking the migration dump does not need sequencers to be running, move this further down.
+        // TODO(DACH-NY/canton-network-node#11099): Once taking the migration dump does not need sequencers to be running, move this further down.
         withClueAndLog("Getting and writing disaster recovery dumps") {
           getAndWriteDumps(identities, timestampBeforeDisaster)
         }

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/DsoElectionTimeBasedIntegrationTest.scala

@@ -20,7 +20,7 @@ class DsoElectionTimeBasedIntegrationTest
 
   private val dummyDsoSynchronizerId = SynchronizerId.tryFromString("domain1::domain")
 
-  // TODO(#7649): once flow is fixed add test to check that SVs can elect a new delegate (currently locked contract issue)
+  // TODO(DACH-NY/canton-network-node#7649): once flow is fixed add test to check that SVs can elect a new delegate (currently locked contract issue)
   "SVs can elect a new delegate and if a delegate gets offboarded a new delegate is chosen while current ElectionRequests are archived" in {
     implicit env =>
       clue("Initialize DSO with 4 SVs") {
@@ -143,7 +143,7 @@ class DsoElectionTimeBasedIntegrationTest
       }
   }
 
-  // TODO(#7649): enable test back if automatic delegate election is re-enabled in new flow
+  // TODO(DACH-NY/canton-network-node#7649): enable test back if automatic delegate election is re-enabled in new flow
   "detect an inactive delegate" ignore { implicit env =>
     val dsoRulesBeforeElection = clue("Initialize DSO with 4 SVs") {
       startAllSync(
@@ -204,7 +204,7 @@ class DsoElectionTimeBasedIntegrationTest
             advanceTime(tickDurationWithBuffer)
           },
           entries => {
-            // TODO(#6856) Consider reverting this to a `forExactly`
+            // TODO(DACH-NY/canton-network-internal#495) Consider reverting this to a `forExactly`
             forAtLeast(3, entries) { line =>
               line.message should include(
                 "Starting check for delegate inactivity"