[static] update TODOs following issue migration #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DA Automation <[email protected]>
| @@ -10,7 +10,7 @@ import Splice.Schedule | |||
| import DA.Time | |||
| import Splice.Util | |||
|
|
|||
| -- TODO(#14972): Get rid of the unused Amulet data type | |||
| -- TODO(#714): Get rid of the unused Amulet data type | |||
There was a problem hiding this comment.
@isegall-da I guess we can't change comments in Daml without also changing the DAR hashes... (which of course breaks static checks) 🤦
There was a problem hiding this comment.
Oh, crap, glad the static checker caught this. Definitely need to revert in daml
Signed-off-by: Itai Segall <[email protected]>
isegall-da
force-pushed
the
isegall/migrate-issues
branch
from
f071f53 to
615250d
Compare
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
|
@ray-roestenburg-da @martinflorian-da Apparently I never merged this (and it was never approved... :( ). Mind hitting the button please? |
moritzkiefer-da
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines