Skip to content
This repository was archived by the owner on Jan 27, 2022. It is now read-only.

Fixing issue with updating work order receipt #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/avalon_sdk/work_order_receipt/work_order_receipt.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def update_receipt(self, work_order_id, update_type,
Returns:
JSON RPC work order update receipt request of type dictionary
"""
data = update_data
data = json.dumps(update_data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 143 also we are converting to serialized string, which is duplicate. instead of line 138 we can use wo_resp_str at 143 and remove serialization at 138.

if update_type in [ReceiptCreateStatus.PROCESSED.value,
ReceiptCreateStatus.COMPLETED.value]:
# Work Order Receipt status is set to be completed or processed,
Expand Down