This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Fixing issue with updating work order receipt #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh-natesh
requested review from
danintel,
dcmiddle,
EugeneYYY,
karthikamurthy,
manju956,
manojgop,
pankajgoyal2,
Ram-srini,
rranjan3,
SriharshaSubbakrishna and
TomBarnes
as code owners
|
You have no commit message, so the build is also failing. Put the message above, including your DCO signature line, in the commit. You can amend your commit with |
- Pushing the fix for the issue hyperledger-archives#693 . - In the file work_order_receipt.py, in line 163, while creating the update receipt - we concatenate the update data to the work order receipt string. The issue is that if the receipt create status has the value FAILED, the update data will be a dictionary, and hence, concatenating it to the string will cause the enclave manager to crash. - Have pushed code to convert this update data into a string so that it can be concatenated. Signed-off-by: snatesh <[email protected]>
sourabh-natesh
force-pushed
the
master
branch
from
c6c29d9 to
3c64cff
Compare
Ram-srini
reviewed
Oct 19, 2020
| @@ -135,7 +135,7 @@ def update_receipt(self, work_order_id, update_type, | |||
| Returns: | |||
| JSON RPC work order update receipt request of type dictionary | |||
| """ | |||
| data = update_data | |||
| data = json.dumps(update_data) | |||
There was a problem hiding this comment.
At line 143 also we are converting to serialized string, which is duplicate. instead of line 138 we can use wo_resp_str at 143 and remove serialization at 138.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing the fix for the issue #693 .
In the file work_order_receipt.py, in line 163, while creating the update receipt - we concatenate the update data to the work order receipt string. The issue is that if the receipt create status has the value FAILED, the update data will be a dictionary, and hence, concatenating it to the string will cause the enclave manager to crash.
Have pushed code to convert this update data into a string so that it can be concatenated.
Signed-off-by: Sourabh Natesh [email protected]