-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scRNASEQ Update #31
Merged
Merged
scRNASEQ Update #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
approved these changes
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Dumb question, but is "Leiden cluster" what we want to show up in the UI? Feels like the sort of thing where from the downstream perspective it feels like it should be an easy change... but it's not.
Thanks!
@@ -27,15 +31,31 @@ def arrow_to_csv(arrow_file, csv_file): | |||
df.to_csv(csv_file) | |||
|
|||
|
|||
def arrow_to_json(arrow_file, json_file): | |||
def arrow_to_json(arrow_file, umap_json, leiden_json): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles part of #30 by outputting clustering assignments as well.
This cwl now outputs into a folder called
output
(rooted wherever this is run from) 4 files for every givenname.h5ad
in the input directory:name.cells.json
name.factors.json
name.arrow
name.csv
@jswelling Just wanted to give you a chance to see the output structure.
@mccalluc can you give a review?
Thanks!