Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scRNASEQ Update #31

Merged
merged 8 commits into from
May 15, 2020
Merged

scRNASEQ Update #31

merged 8 commits into from
May 15, 2020

Conversation

ilan-gold
Copy link
Member

This handles part of #30 by outputting clustering assignments as well.

This cwl now outputs into a folder called output (rooted wherever this is run from) 4 files for every given name.h5ad in the input directory:

  • name.cells.json
  • name.factors.json
  • name.arrow
  • name.csv

@jswelling Just wanted to give you a chance to see the output structure.

@mccalluc can you give a review?

Thanks!

@ilan-gold ilan-gold requested review from mccalluc and jswelling May 14, 2020 21:56
@ilan-gold
Copy link
Member Author

Updated some things to make it display a little nicer in Vitessce:

Screen Shot 2020-05-14 at 7 51 52 PM

Screen Shot 2020-05-14 at 7 51 47 PM

Copy link
Contributor

@mccalluc mccalluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Dumb question, but is "Leiden cluster" what we want to show up in the UI? Feels like the sort of thing where from the downstream perspective it feels like it should be an easy change... but it's not.

Thanks!

@@ -27,15 +31,31 @@ def arrow_to_csv(arrow_file, csv_file):
df.to_csv(csv_file)


def arrow_to_json(arrow_file, json_file):
def arrow_to_json(arrow_file, umap_json, leiden_json):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider kwargs

@ilan-gold ilan-gold merged commit 3f19e50 into master May 15, 2020
@ilan-gold ilan-gold deleted the ilan-gold/scRNASEQ-update branch May 15, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants