Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add niko_home_control quality scale #134000

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
+87 −1
Draft

Add niko_home_control quality scale #134000

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2453f
Add quality scale
VandeurenGlenn Dec 25, 2024
04f8b56
Update quality_scale.yaml
VandeurenGlenn Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions homeassistant/components/niko_home_control/quality_scale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
rules:
# Bronze
brands: done
common-modules: done
config-flow-test-coverage: done
config-flow: done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more specific in the config flow with catching exceptions

dependency-transparency: done
docs-installation-instructions: done
entity-unique-id: done
has-entity-name: done
runtime-data: done
test-before-configure: done
test-before-setup: done
unique-config-entry: done

# Silver
config-entry-unloading: done
entity-unavailable: todo
integration-owner: done
log-when-unavailable: todo
test-coverage: todo

# Gold
devices: done
discovery: todo
docs-supported-devices: todo
docs-troubleshooting: todo
docs-use-cases: todo
dynamic-devices: todo
entity-category: todo
entity-device-class: todo
entity-translations: todo
exception-translations: done
icon-translations: todo
reconfiguration-flow: todo
repair-issues: done
stale-devices: todo

# Platinum
async-dependency: done
strict-typing: todo
1 change: 0 additions & 1 deletion script/hassfest/quality_scale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,6 @@ class Rule:
"nibe_heatpump",
"nice_go",
"nightscout",
"niko_home_control",
"nilu",
"nina",
"nissan_leaf",
Expand Down