Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add niko_home_control quality scale #134000

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

VandeurenGlenn
Copy link
Contributor

@VandeurenGlenn VandeurenGlenn commented Dec 25, 2024

Proposed change

Add quality scale to niko_home_control

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@VandeurenGlenn VandeurenGlenn marked this pull request as ready for review December 25, 2024 14:32
@VandeurenGlenn VandeurenGlenn requested a review from a team as a code owner December 25, 2024 14:32
@MartinHjelmare MartinHjelmare changed the title code-quality(niko_home_control): Add quality scale Add niko_home_control quality scale Dec 25, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the full YAML here and not just a subset of all the rules

brands: done
common-modules: done
config-flow-test-coverage: done
config-flow: done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more specific in the config flow with catching exceptions

@home-assistant home-assistant bot marked this pull request as draft December 26, 2024 11:08
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@VandeurenGlenn
Copy link
Contributor Author

Let's add the full YAML here and not just a subset of all the rules

Well, hassfest didn't complain :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants