-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add niko_home_control quality scale #134000
base: dev
Are you sure you want to change the base?
Add niko_home_control quality scale #134000
Conversation
1064863
to
4bc59dd
Compare
4bc59dd
to
cb2453f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the full YAML here and not just a subset of all the rules
brands: done | ||
common-modules: done | ||
config-flow-test-coverage: done | ||
config-flow: done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be more specific in the config flow with catching exceptions
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Well, hassfest didn't complain :p |
Proposed change
Add quality scale to niko_home_control
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: