Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): upgrade material ui #844

Merged
merged 8 commits into from
Dec 9, 2024
Merged

(chore): upgrade material ui #844

merged 8 commits into from
Dec 9, 2024

Conversation

ilan-gold
Copy link
Collaborator

@ilan-gold ilan-gold commented Nov 26, 2024

Background

For #745 (comment)

Change List

  • Upgrade Material UI to 6.x.x

Checklist

  • Update JSdoc types if there is any API change.
  • Make sure Avivator works as expected with your change.

@ilan-gold
Copy link
Collaborator Author

Before:
Screenshot 2024-11-26 at 14 15 09

After:
Screenshot 2024-11-26 at 14 15 04

I will try to figure out if the un-whitened buttons are a bug or a feature but anyone is welcome to chime in. It could be a good design principle, really unsure.

@ilan-gold ilan-gold requested a review from manzt November 29, 2024 10:41
@ilan-gold
Copy link
Collaborator Author

ilan-gold commented Nov 29, 2024

@manzt You can review the code (although large swaths of it are from the codemods they made available), but I would be probably more interested in a user-test to help to sniff out bugs if they were introduced.

@manzt
Copy link
Member

manzt commented Dec 3, 2024

thanks for making the pr! i won’t have time to review these changes until after my defense unfortunately

@ilan-gold
Copy link
Collaborator Author

Ah ok @manzt I may just try to be extra careful and then merge-as-is if I don't find anything.

@ilan-gold ilan-gold merged commit f64920e into main Dec 9, 2024
5 checks passed
@ilan-gold ilan-gold deleted the ig/upgrade_mui branch December 9, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants