Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate D.B.getLine/hGetLine in favor of D.B.Char8 #597

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Deprecate D.B.getLine/hGetLine in favor of D.B.Char8 #597

merged 1 commit into from
Jun 24, 2023

Conversation

Bodigrim
Copy link
Contributor

Fixes #249.

@Bodigrim Bodigrim added this to the 0.11.5.0 milestone Jun 16, 2023
@Bodigrim Bodigrim requested a review from clyring June 16, 2023 22:13
@Bodigrim
Copy link
Contributor Author

Not sure if it’s worth backporting to 0.11 series. Maybe target 0.12 only, this deprecation is low priority anyways.

@clyring clyring modified the milestones: 0.11.5.0, 0.12.0.0 Jun 20, 2023
clyring
clyring approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@clyring clyring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safer not to backport this. PVP after haskell/pvp#12 is not very clear on the matter; we have one entity becoming two, which can cause "ambiguous occurrence" errors downstream.

I like deprecated-since comments. Add them if you like (or don't), then let's merge.

Data/ByteString/Char8.hs
@@ -2,6 +2,7 @@
{-# LANGUAGE MagicHash #-}
{-# OPTIONS_HADDOCK prune #-}
{-# LANGUAGE Trustworthy #-}
{-# OPTIONS_GHC -Wno-deprecations #-}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit sad that there's currently no way to silence just the two specific deprecation warnings we expect.

@Bodigrim Bodigrim merged commit 4672a57 into haskell:master Jun 24, 2023
@Bodigrim Bodigrim deleted the deprecate-getLine branch June 24, 2023 19:31
@clyring clyring mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clyring clyring clyring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0.0
Development

Successfully merging this pull request may close these issues.

Should D.B.{getLine,hGetLine} be deprecated similarly to putStrLn and hPutStrLn?
2 participants
@Bodigrim @clyring