Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update the changelog #596

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

clyring
Copy link
Member

@clyring clyring commented Jun 13, 2023

No description provided.

@Bodigrim
Copy link
Contributor

Bodigrim commented Jul 2, 2023

@clyring do you have capacity to finialise this soon?

Copy link
Member Author

@clyring clyring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bodigrim Sure. I think none of the TODO items are blockers. This is only missing #597 relative to master.

Changelog.md Outdated
* The compatibility package `data-array-byte` is used when `base` does not provide `Data.Array.Byte`.
* [`fromListN` from `instance IsList ShortByteString` now throws an exception if the first argument does not match the length of the second](https://github.com/haskell/bytestring/pull/410)
* Previously, it would ignore the first argument entirely.
* TODO: Should we make the analogous change for the other ByteString flavors?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I experimented locally with such a change. I was surprised to find that it had no measurable performance impact on my machine at the (reasonably small) sizes I benchmarked, unless list fusion happened. But I didn't really want to stick INLINE on the function to make it fuse and didn't yet bother playing with rewrite rules.

I propose we just live with this inconsistency for 0.12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, let's go.

@Bodigrim
Copy link
Contributor

Bodigrim commented Jul 6, 2023

LGTM, feel free to release.

@clyring clyring merged commit 88f16dc into haskell:master Jul 6, 2023
@clyring clyring added this to the 0.12.0.0 milestone Jul 6, 2023
clyring added a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants