WIP: Update the changelog #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clyring do you have capacity to finialise this soon? |
clyring
commented
Jul 5, 2023
Changelog.md
Outdated
| * The compatibility package `data-array-byte` is used when `base` does not provide `Data.Array.Byte`. | ||
| * [`fromListN` from `instance IsList ShortByteString` now throws an exception if the first argument does not match the length of the second](https://github.com/haskell/bytestring/pull/410) | ||
| * Previously, it would ignore the first argument entirely. | ||
| * TODO: Should we make the analogous change for the other ByteString flavors? |
There was a problem hiding this comment.
I experimented locally with such a change. I was surprised to find that it had no measurable performance impact on my machine at the (reasonably small) sizes I benchmarked, unless list fusion happened. But I didn't really want to stick INLINE on the function to make it fuse and didn't yet bother playing with rewrite rules.
I propose we just live with this inconsistency for 0.12.
Bodigrim
approved these changes
Jul 6, 2023
|
LGTM, feel free to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.