-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gradle build script for ui project #5314
Add Gradle build script for ui project #5314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5314 +/- ##
=========================================
Coverage 56.91% 56.91%
Complexity 3319 3319
=========================================
Files 587 587
Lines 18968 18968
Branches 1401 1401
=========================================
Hits 10795 10795
Misses 7594 7594
Partials 579 579 ☔ View full report in Codecov by Sentry. |
Signed-off-by: John Niang <[email protected]>
b1340f2
to
a3772fa
Compare
Hi @ruibaby , I have already proposed another PR halo-dev/docs#308 for adapting corresponding documentation. |
我运行 ./gradlew build 无法成功。 |
Hi @ruibaby ,请先删除 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hi @ruibaby ,现在有一个小问题,如果我们在 IDEA 通过 Gradle 运行项目或者直接通过 当然,也可以通过 |
建议仅在 build 的时候去执行 ui 的 build,即便是开发环境,也推荐单独执行 :ui:dev。 |
Signed-off-by: John Niang <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have to merge this PR manually due to workflow files changed. |
This PR mainly adapts PR <halo-dev/halo#5314>. ```release-note None ```
#### What type of PR is this? /area ui /kind cleanup #### What this PR does / why we need it: Rename console to ui in some files, Ref #5314 #### Does this PR introduce a user-facing change? ```release-note None ```
#### What type of PR is this? /kind cleanup /area core #### What this PR does / why we need it: The wrong `pre-commit` will prevent us from making a Git commit. The problem was caused by <#5314>. ```bash ui/.husky/pre-commit: line 4: cd: console: No such file or directory husky - pre-commit hook exited with code 1 (error) ``` #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/kind cleanup
/kind feature
/area core
/milestone 2.13.x
What this PR does / why we need it:
This PR moves
console
folder toui
and add Gradle build script for ui project. Afterwards, we will no longer need to executemake -C console build
before executing./gradlew build
.Please note that the main commit is b1340f2.
Which issue(s) this PR fixes:
Fixes #5061
Special notes for your reviewer:
Execute command
./gradlew build
and try to run the artifact by executing commandjava -jar application/build/libs/halo-2.13.0-SNAPSHOT.jar
Does this PR introduce a user-facing change?