Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename console to ui in some files #5347

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 7, 2024

What type of PR is this?

/area ui
/kind cleanup

What this PR does / why we need it:

Rename console to ui in some files,

Ref #5314

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/ui Issues or PRs related to the Halo UI labels Feb 7, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui February 7, 2024 14:11
@f2c-ci-robot f2c-ci-robot bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 7, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen February 7, 2024 14:11
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77a34c1) 56.91% compared to head (0b77e00) 56.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5347   +/-   ##
=========================================
  Coverage     56.91%   56.91%           
  Complexity     3319     3319           
=========================================
  Files           587      587           
  Lines         18968    18968           
  Branches       1401     1401           
=========================================
  Hits          10795    10795           
  Misses         7594     7594           
  Partials        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
Copy link

f2c-ci-robot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 8ce6ab6 into halo-dev:main Feb 7, 2024
8 checks passed
@ruibaby ruibaby deleted the chore/rename-to-ui branch March 24, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants