Add terminate cli argument for shell-command. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a new event occurs whilst the current one is still in progress, it terminates the Popen and runs the command anew.
|
I think .terminate is sufficient, at least for my work. Perhaps there is a need for more (hence the sledgehammer comment), specifically AutoRestart.Trick.stop does some magic to kill all spawned tasks (presumably terminate doesn't do this)? |
|
👋🏽 I want this! How can I help having this merged? |
Any help would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new event occurs whilst the current one is still in progress, it
terminates the Popen and runs the command anew.