Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pytest-watch - DIA-46202 #67

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

hadrien
Copy link
Member

@hadrien hadrien commented Oct 5, 2022

Description

  • pytest-watch is not maintained anymore and is not compatible with toml config;
  • We were using a branch of the git repo which caused publishing the package on pypi to fail:

    HTTP Error 400: Invalid value for requires_dist. Error: Can't have direct dependency: 'pytest-watch @ git+https://github.com/aldencolerain/pytest-watch.git@fix-toml-config ; extra == "tests"'

Related issues

Related PRs

Copy link
Contributor

@vicrep vicrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any alternative to ptw?

@hadrien hadrien requested a review from vicrep October 5, 2022 20:31
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #67 (b601439) into master (007cd98) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          370       370           
  Branches        24        15    -9     
=========================================
  Hits           370       370           
Flag Coverage Δ
sqlalchemy1.3-asyncpg-aws_rds_iam 65.40% <ø> (ø)
sqlalchemy1.3-asyncpg-noaws_rds_iam 63.24% <ø> (ø)
sqlalchemy1.3-noasyncpg-aws_rds_iam 65.13% <ø> (ø)
sqlalchemy1.3-noasyncpg-noaws_rds_iam 62.97% <ø> (ø)
sqlalchemy1.4-asyncpg-aws_rds_iam 96.75% <ø> (ø)
sqlalchemy1.4-asyncpg-noaws_rds_iam 94.59% <ø> (ø)
sqlalchemy1.4-noasyncpg-aws_rds_iam 77.29% <ø> (ø)
sqlalchemy1.4-noasyncpg-noaws_rds_iam 75.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hadrien
Copy link
Member Author

hadrien commented Oct 5, 2022

Is there any alternative to ptw?

pytest-watch uses watchdog which can be used directly.

I made myself a script in ~/Applications/ptw:

#!/bin/sh -x

/bin/sh -c "$*"

watchmedo shell-command \
  --wait \
  --patterns '*.py;*.txt,*.toml,*.md,*.yml' \
  --recursive \
  --command "$*" \
  $PWD

Usage: ptw pytest -x --lf ...

Only drawback: it does not interrupt when a filesystem event occurs -> gorakhargosh/watchdog#319

@hadrien hadrien merged commit 4f02815 into master Oct 5, 2022
@hadrien hadrien deleted the chore/DIA-46202/remove-pytest-watch branch October 5, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants