Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-31065: [IOSA-SUP] Reported content cannot be seen or deleted from the Report Overview Page #4190

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

kashandarash
Copy link
Contributor

@kashandarash kashandarash commented Nov 20, 2024

Problem (for internal)

Reported content cannot be seen or deleted from the Report Overview Page by a Site Admin role. Please see the attachment, there is no option to delete and also when clicked on the view comment it doesn't direct to the comment, the user stays at the page. If we try to delete the reported content from the post itself, it gives the following message and do not delete. {"message":"The "comment" parameter was not converted for the path "/ajax_comments/{comment}/delete" (route name: "ajax_comments.delete")"} Reported contents can only be deleted from content overview page.

Solution (for internal)

Rework the reports page to add a delete option, filters and fix errors on the view action.
The destination parameter was removed from action links because it breaks a redirect that exists on routes.

Screenshot 2024-11-20 at 11 29 48

Release notes (to customers)

The Reports page (/admin/content/reports) was updated, direct link to remove content and filters by type and status were added.

Issue tracker

https://getopensocial.atlassian.net/browse/PROD-31065

Theme issue tracker

How to test

  • Install Open Social
  • Report Content
  • Go to /admin/content/reports page
  • Filters and action links should work without errors

Change Record

Translations

@kashandarash kashandarash changed the title PROD-31065, PROD-31065: [IOSA-SUP] Reported content cannot be seen or deleted from the Report Overview Page Nov 20, 2024
@kashandarash kashandarash added this to the 12.3.9 milestone Nov 20, 2024
@kashandarash kashandarash self-assigned this Nov 20, 2024
@kashandarash kashandarash force-pushed the issue/PROD-31065 branch 3 times, most recently from 419828f to 0030d37 Compare November 20, 2024 11:10
@Orest-Solinskyi
Copy link

Tested! Reported issues were fixed. Also, the added improvements work well. Some FE works for button position is needed but it's a low prio issue now
Screenshot 2024-11-20 at 17 03 12

@kashandarash
Copy link
Contributor Author

Tested! Reported issues were fixed. Also, the added improvements work well. Some FE works for button position is needed but it's a low prio issue now Screenshot 2024-11-20 at 17 03 12

Other admin pages have this issue as well, so I don't think we should fix it is the scope of this ticket
Screenshot 2024-11-20 at 18 07 05

@v-kovaliks v-kovaliks self-requested a review November 21, 2024 16:32
Copy link
Contributor

@v-kovaliks v-kovaliks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Screenshot 2024-11-21 at 18 56 14
Screenshot 2024-11-21 at 18 53 17

@kashandarash kashandarash merged commit c055472 into main Nov 21, 2024
196 of 198 checks passed
@kashandarash kashandarash deleted the issue/PROD-31065 branch November 21, 2024 17:02
@tbsiqueira tbsiqueira added the scope: community management system This change impacts all customers that use the community management system label Nov 27, 2024
@ronaldtebrake ronaldtebrake removed this from the 12.3.9 milestone Nov 28, 2024
Copy link

Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them.

Missing milestone
The issue is missing a milestone. Milestones are important to help release managers know whether they might need to postpone a release for a critical issue and to communicate what fixes and new features are included in a release. Before merging, please select the appropriate milestone for this pull request.

🤖 This is an automatically produced message by the Open Social PR manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium scope: community management system This change impacts all customers that use the community management system team: iata type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

5 participants