Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-31065: [IOSA-SUP] Reported content cannot be seen or deleted from the Report Overview Page #4219

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

kashandarash
Copy link
Contributor

@kashandarash kashandarash commented Nov 29, 2024

Problem (for internal)

Reported content cannot be seen or deleted from the Report Overview Page by a Site Admin role. Please see the attachment, there is no option to delete and also when clicked on the view comment it doesn't direct to the comment, the user stays at the page. If we try to delete the reported content from the post itself, it gives the following message and do not delete. {"message":"The "comment" parameter was not converted for the path "/ajax_comments/{comment}/delete" (route name: "ajax_comments.delete")"} Reported contents can only be deleted from content overview page.

Solution (for internal)

Rework the reports page to add a delete option, filters and fix errors on the view action.
The destination parameter was removed from action links because it breaks a redirect that exists on routes.

Release notes (to customers)

The Reports page (/admin/content/reports) was updated, direct link to remove content and filters by type and status were added.

Issue tracker

https://getopensocial.atlassian.net/browse/PROD-31065
https://www.drupal.org/project/social/issues/3491262

Theme issue tracker

How to test

  • Install Open Social
  • Report Content
  • Go to /admin/content/reports page
  • Filters and action links should work without errors

There was another PR #4190 that was declined because the update path was not provided, the only difference now is hook update, so we need to check only this.

Change Record

Translations

@kashandarash kashandarash added type: bug Fixes a bug in Open Social prio: high team: iata labels Nov 29, 2024
@kashandarash kashandarash added this to the 12.3.10 milestone Nov 29, 2024
@kashandarash kashandarash self-assigned this Nov 29, 2024
@Orest-Solinskyi
Copy link

This PR was tested and approved on November 20

@v-kovaliks v-kovaliks self-requested a review December 3, 2024 12:05
Copy link
Contributor

@v-kovaliks v-kovaliks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Approve from my side, hook_update works correctly
Screenshot 2024-12-03 at 14 06 32
Screenshot 2024-12-03 at 14 06 24

@robertragas robertragas merged commit f1cbe1b into main Dec 3, 2024
196 of 198 checks passed
@robertragas robertragas deleted the issue/PROD-31065 branch December 3, 2024 12:30
@robertragas
Copy link
Collaborator

I changed the milestone to 13.0.0-alpha19.

If it really needs to be in 12.3.x and 12.4.x, then it needs to be cherry-picked but also update_hook number should be adjusted accordingly to avoid conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high team: iata type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

4 participants