Add DNS provider for RU Center #1892

AntonDzyk · 2023-04-12T11:09:18Z

ldez · 2023-04-12T12:06:42Z

Hello, in order for a PR adding a DNS provider to be accepted, you have to:

add a description to your PR
be able to maintain this provider
have a homogeneous design with the other providers
add tests (units)

make test

add tests ("live")

lego/providers/dns/cloudflare/cloudflare_test.go

Lines 125 to 151 in c938de6

    
           func TestLivePresent(t *testing.T) { 
        
           	if !envTest.IsLiveTest() { 
        
           		t.Skip("skipping live test") 
        
           	} 
        
           	envTest.RestoreEnv() 
        
           	provider, err := NewDNSProvider() 
        
           	require.NoError(t, err) 
        
           	err = provider.Present(envTest.GetDomain(), "", "123d==") 
        
           	require.NoError(t, err) 
        
           } 
        
           func TestLiveCleanUp(t *testing.T) { 
        
           	if !envTest.IsLiveTest() { 
        
           		t.Skip("skipping live test") 
        
           	} 
        
           	envTest.RestoreEnv() 
        
           	provider, err := NewDNSProvider() 
        
           	require.NoError(t, err) 
        
           	time.Sleep(2 * time.Second) 
        
           	err = provider.CleanUp(envTest.GetDomain(), "", "123d==") 
        
           	require.NoError(t, err) 
        
           }

make test

add a provider descriptor
generate CLI help, documentation, and readme.

make generate-dns

be able to do: (and put the output of this command to a comment in your PR)

rm -rf .lego

./lego -m [email protected] --dns YOUR_PROVIDER_NAME -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

pass the linter (golangci-lint must be installed):

make checks

do go mod tidy

ldez · 2023-04-12T22:28:26Z

Your PR was far away from the design of the other implementations, so I rewrite it and add tests on the client.

You can check my previous comment to know what are the next requirements.

ldez · 2023-04-13T16:14:16Z

ping @AntonDzyk

ldez · 2023-04-22T16:29:36Z

@AntonDzyk can you provide the missing information?
#1892 (comment)

ldez · 2023-05-15T09:53:15Z

ping @AntonDzyk

ldez · 2023-06-07T12:50:50Z

I'm still waiting for feedback @AntonDzyk.

If a user wants to help this PR by testing it, you are welcome to do so.

How to test this PR?

You need Go

Checkout the PR:

git clone https://github.com/AntonDzyk/lego.git
cd lego
git checkout master

Compile lego:
- if you have make: make build
- if you don't make make: go build -o dist/lego ./cmd/lego

Run the following command with your own information (email, domain, credentials):

NICRU_USER="<your_user>" \
NICRU_PASSWORD="<your_password>" \
NICRU_SERVICE_ID="<service_id>" \
NICRU_SECRET="<service_secret>" \
NICRU_SERVICE_NAME="<service_name>" \
./dist/lego --dns nicru --domains "*.example.com" -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

The wildcard domain is important

Before each run of the command, you should clean your local environment:
```
rm -rf .lego
```

livebreakz · 2024-11-20T11:56:14Z

Please explain what are:

NICRU_SERVICE_ID="<service_id>" \
NICRU_SECRET="<service_secret>" \
NICRU_SERVICE_NAME="<service_name>" \

ldez · 2024-11-20T12:01:25Z

I don't know how to find the values to set because I'm not the author of this PR, but I think this is explained here: https://github.com/go-acme/lego/pull/1892/files#diff-033dbf5a6431a24266bee1b693b19c924755b239fe9109cc22a9e56732540874R17-R27

livebreakz · 2024-11-20T12:22:56Z

Should i edit nicru.toml to test?

ldez · 2024-11-20T13:04:56Z

no, this file is documentation, you should read it.

You can find information about service ID and secret https://www.nic.ru/manager/oauth.cgi?step=oauth.app_list

ENV Variable Parameter from page Example

NICRU_USER Username (Number of agreement) NNNNNNN/NIC-D

NICRU_PASSWORD Password account

NICRU_SERVICE_ID Application ID hex-based, len 32

NICRU_SECRET Identity endpoint string len 91

NICRU_SERVICE_NAME Service name in DNS-hosting DPNNNNNNNNNN

NICRU_USER="NNNNNNN/NIC-D" \
NICRU_PASSWORD="xxx" \
NICRU_SERVICE_ID="yyy" \
NICRU_SECRET="zzz" \
NICRU_SERVICE_NAME="DPNNNNNNNNNN" \
./dist/lego --dns nicru --domains "*.example.com" -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

livebreakz · 2024-11-21T13:37:49Z

Error:

2024/11/21 16:37:04 [INFO] [gptev.ru] acme: Obtaining bundled SAN certificate
2024/11/21 16:37:05 [INFO] [gptev.ru] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172396693/15019640784
2024/11/21 16:37:05 [INFO] [gptev.ru] acme: Could not find solver for: tls-alpn-01
2024/11/21 16:37:05 [INFO] [gptev.ru] acme: Could not find solver for: http-01
2024/11/21 16:37:05 [INFO] [gptev.ru] acme: use dns-01 solver
2024/11/21 16:37:05 [INFO] [gptev.ru] acme: Preparing to solve DNS-01
2024/11/21 16:37:05 [INFO] [gptev.ru] acme: Cleaning DNS-01 challenge
2024/11/21 16:37:05 [WARN] [gptev.ru] acme: cleaning up failed: nicru: zone UUID not found for gptev.ru
2024/11/21 16:37:06 [INFO] Deactivating auth: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172396693/15019640784
2024/11/21 16:37:06 Could not obtain certificates:
        error: one or more domains had a problem:
[gptev.ru] [gptev.ru] acme: error presenting token: nicru: zone UUID not found for gptev.ru

ldez · 2024-11-21T13:44:36Z

I added logs can you try again?

livebreakz · 2024-11-21T13:50:00Z

I think same result:

./dist/lego --email "[email protected]" --dns nicru --domains "gptev.ru" -s https://acme-staging-v02.api.letsencrypt.org/directory run
2024/11/21 16:49:09 No key found for account [email protected]. Generating a P256 key.
2024/11/21 16:49:09 Saved key to /mnt/c/Users/yashukovd/lego/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2024/11/21 16:49:10 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.4-April-3-2024.pdf
Do you accept the TOS? Y/n
y
2024/11/21 16:49:13 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!

Your account credentials have been saved in your Let's Encrypt
configuration directory at "/mnt/c/Users/yashukovd/lego/.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from Let's Encrypt so making regular
backups of this folder is ideal.
2024/11/21 16:49:14 [INFO] [gptev.ru] acme: Obtaining bundled SAN certificate
2024/11/21 16:49:14 [INFO] [gptev.ru] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172579884/15019776494
2024/11/21 16:49:14 [INFO] [gptev.ru] acme: Could not find solver for: tls-alpn-01
2024/11/21 16:49:14 [INFO] [gptev.ru] acme: Could not find solver for: http-01
2024/11/21 16:49:14 [INFO] [gptev.ru] acme: use dns-01 solver
2024/11/21 16:49:14 [INFO] [gptev.ru] acme: Preparing to solve DNS-01
2024/11/21 16:49:14 [INFO] [gptev.ru] acme: Cleaning DNS-01 challenge
2024/11/21 16:49:15 [WARN] [gptev.ru] acme: cleaning up failed: nicru: zone UUID not found for gptev.ru
2024/11/21 16:49:15 [INFO] Deactivating auth: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172579884/15019776494
2024/11/21 16:49:15 Could not obtain certificates:
        error: one or more domains had a problem:
[gptev.ru] [gptev.ru] acme: error presenting token: nicru: zone UUID not found for gptev.ru

livebreakz · 2024-11-21T13:51:28Z

By the way i think "NICRU_SERVICE_NAME" is deprecated or something, cannot find it anywhere

ldez · 2024-11-21T13:51:43Z

have you pulled the branch before trying?
Because at least one new log should always appear.

ldez · 2024-11-21T13:54:35Z

By the way i think "NICRU_SERVICE_NAME" is deprecated or something, cannot find it anywhere

I don't think so, because it's inside the API doc: https://www.nic.ru/help/upload/file/API_DNS-hosting.pdf

livebreakz · 2024-11-21T13:57:43Z

Did reset and pull and repeated command

ldez · 2024-11-21T14:00:13Z

I added another log, this log will always be displayed.

livebreakz · 2024-11-21T14:04:35Z

repeated procedure
see no changes )

ldez · 2024-11-21T14:08:02Z

do you have a new log: checkZoneUUID: xxx?

ldez · 2024-11-21T14:08:35Z

Have you re-compiled lego?

livebreakz · 2024-11-21T14:12:23Z

2024/11/21 17:11:15 No key found for account [email protected]. Generating a P256 key.
2024/11/21 17:11:15 Saved key to /mnt/c/Users/yashukovd/lego/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2024/11/21 17:11:16 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.4-April-3-2024.pdf
Do you accept the TOS? Y/n
y
2024/11/21 17:11:18 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!

Your account credentials have been saved in your Let's Encrypt
configuration directory at "/mnt/c/Users/yashukovd/lego/.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from Let's Encrypt so making regular
backups of this folder is ideal.
2024/11/21 17:11:18 [INFO] [gptev.ru] acme: Obtaining bundled SAN certificate
2024/11/21 17:11:19 [INFO] [gptev.ru] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172583014/15020050544
2024/11/21 17:11:19 [INFO] [gptev.ru] acme: Could not find solver for: tls-alpn-01
2024/11/21 17:11:19 [INFO] [gptev.ru] acme: Could not find solver for: http-01
2024/11/21 17:11:19 [INFO] [gptev.ru] acme: use dns-01 solver
2024/11/21 17:11:19 [INFO] [gptev.ru] acme: Preparing to solve DNS-01
2024/11/21 17:11:19 [INFO] checkZoneUUID: gptev.ru
2024/11/21 17:11:19 [INFO] zones count: 0
2024/11/21 17:11:19 [INFO] [gptev.ru] acme: Cleaning DNS-01 challenge
2024/11/21 17:11:19 [INFO] checkZoneUUID: gptev.ru
2024/11/21 17:11:19 [INFO] zones count: 0
2024/11/21 17:11:19 [WARN] [gptev.ru] acme: cleaning up failed: nicru: zone UUID not found for gptev.ru
2024/11/21 17:11:19 [INFO] Deactivating auth: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172583014/15020050544
2024/11/21 17:11:20 Could not obtain certificates:
        error: one or more domains had a problem:
[gptev.ru] [gptev.ru] acme: error presenting token: nicru: zone UUID not found for gptev.ru

ldez · 2024-11-21T14:16:56Z

2024/11/21 17:11:19 [INFO] checkZoneUUID: gptev.ru
2024/11/21 17:11:19 [INFO] zones count: 0

So I think your service name (NICRU_SERVICE_NAME) is not right.

ldez · 2024-11-21T14:25:13Z

I added an extra call, only for debugging purposes, to display all your services.

livebreakz · 2024-11-25T06:13:07Z

Set NICRU_SERVICE_NAME value the same as NICRU_USER value

./dist/lego --email "[email protected]" --dns nicru --domains "gptev.ru" -s https://acme-staging-v02.api.letsencrypt.org/directory run
2024/11/25 09:04:24 [INFO] [gptev.ru] acme: Obtaining bundled SAN certificate
2024/11/25 09:04:24 [INFO] [gptev.ru] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172583014/15074184644
2024/11/25 09:04:24 [INFO] [gptev.ru] acme: Could not find solver for: tls-alpn-01
2024/11/25 09:04:24 [INFO] [gptev.ru] acme: Could not find solver for: http-01
2024/11/25 09:04:24 [INFO] [gptev.ru] acme: use dns-01 solver
2024/11/25 09:04:24 [INFO] [gptev.ru] acme: Preparing to solve DNS-01
2024/11/25 09:04:24 [INFO] checkZoneUUID: gptev.ru
2024/11/25 09:04:25 [INFO] [gptev.ru] acme: Cleaning DNS-01 challenge
2024/11/25 09:04:25 [INFO] checkZoneUUID: gptev.ru
2024/11/25 09:04:25 [WARN] [gptev.ru] acme: cleaning up failed: nicru: unable to fetch dns zones: [status code=404] decode XML response:
2024/11/25 09:04:25 [INFO] Deactivating auth: https://acme-staging-v02.api.letsencrypt.org/acme/authz/172583014/15074184644
2024/11/25 09:04:25 Could not obtain certificates:
error: one or more domains had a problem:
[gptev.ru] [gptev.ru] acme: error presenting token: nicru: unable to fetch dns zones: [status code=404] decode XML response:

AntonDzyk mentioned this pull request Apr 12, 2023

Add DNS Provider for RU CENTER #1891

Open

1 task

ldez changed the title ~~Add DNS provider for RU CENTER (#1891)~~ Add DNS provider for RU CENTER Apr 12, 2023

ldez added enhancement area/dnsprovider labels Apr 12, 2023

ldez self-requested a review April 12, 2023 12:06

ldez force-pushed the master branch from ff0bb62 to 9a8d9b6 Compare April 12, 2023 17:30

ldez added the contrib/waiting-for-feedback label Apr 12, 2023

ldez force-pushed the master branch 2 times, most recently from 5a203b9 to 4f9e9d4 Compare April 12, 2023 19:08

ldez changed the title ~~Add DNS provider for RU CENTER~~ Add DNS provider for RU Center Apr 12, 2023

ldez force-pushed the master branch from 4f9e9d4 to 227b62d Compare April 12, 2023 20:58

ldez force-pushed the master branch 3 times, most recently from 19e63c8 to 1070f0d Compare May 5, 2023 08:38

ldez added the state/need-user-tests Need users to test functionality label Jun 7, 2023

ldez mentioned this pull request Jun 27, 2023

Add DNS provider for Efficient IP #1945

Merged

8 tasks

ldez closed this in #1945 Jul 1, 2023

ldez reopened this Jul 1, 2023

ldez force-pushed the master branch 3 times, most recently from b848556 to a0828b0 Compare February 11, 2024 13:48

ldez removed the contrib/waiting-for-feedback label Mar 5, 2024

ldez force-pushed the master branch from a0828b0 to a57b61f Compare October 14, 2024 13:17

ldez force-pushed the master branch from a57b61f to 578b35d Compare October 26, 2024 11:01

ldez marked this pull request as draft October 26, 2024 11:02

ldez force-pushed the master branch from 578b35d to 97bfda2 Compare November 3, 2024 14:37

AntonDzyk and others added 3 commits November 19, 2024 05:13

Add DNS provider for RU CENTER (go-acme#1891)

d862ad7

review

e07a297

chore: generate

128277c

ldez force-pushed the master branch from 97bfda2 to 128277c Compare November 19, 2024 04:14

debug: add logs

85f9007

ldez force-pushed the master branch from 6df121a to 85f9007 Compare November 21, 2024 13:44

debug: add logs

f854bc3

debug: list services

5def332

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DNS provider for RU Center #1892

Add DNS provider for RU Center #1892

AntonDzyk commented Apr 12, 2023 •

edited by ldez

Loading

ldez commented Apr 12, 2023 •

edited

Loading

ldez commented Apr 12, 2023

ldez commented Apr 13, 2023

ldez commented Apr 22, 2023

ldez commented May 15, 2023

ldez commented Jun 7, 2023 •

edited

Loading

livebreakz commented Nov 20, 2024 •

edited by ldez

Loading

ldez commented Nov 20, 2024

livebreakz commented Nov 20, 2024

ldez commented Nov 20, 2024 •

edited

Loading

livebreakz commented Nov 21, 2024 •

edited by ldez

Loading

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024 •

edited by ldez

Loading

livebreakz commented Nov 21, 2024

ldez commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024

ldez commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024 •

edited by ldez

Loading

ldez commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 25, 2024

Add DNS provider for RU Center #1892

Are you sure you want to change the base?

Add DNS provider for RU Center #1892

Conversation

AntonDzyk commented Apr 12, 2023 • edited by ldez Loading

ldez commented Apr 12, 2023 • edited Loading

ldez commented Apr 12, 2023

ldez commented Apr 13, 2023

ldez commented Apr 22, 2023

ldez commented May 15, 2023

ldez commented Jun 7, 2023 • edited Loading

livebreakz commented Nov 20, 2024 • edited by ldez Loading

ldez commented Nov 20, 2024

livebreakz commented Nov 20, 2024

ldez commented Nov 20, 2024 • edited Loading

livebreakz commented Nov 21, 2024 • edited by ldez Loading

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024 • edited by ldez Loading

livebreakz commented Nov 21, 2024

ldez commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024

ldez commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 21, 2024 • edited by ldez Loading

ldez commented Nov 21, 2024

ldez commented Nov 21, 2024

livebreakz commented Nov 25, 2024

AntonDzyk commented Apr 12, 2023 •

edited by ldez

Loading

ldez commented Apr 12, 2023 •

edited

Loading

ldez commented Jun 7, 2023 •

edited

Loading

livebreakz commented Nov 20, 2024 •

edited by ldez

Loading

ldez commented Nov 20, 2024 •

edited

Loading

livebreakz commented Nov 21, 2024 •

edited by ldez

Loading

livebreakz commented Nov 21, 2024 •

edited by ldez

Loading

livebreakz commented Nov 21, 2024 •

edited by ldez

Loading