Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for Efficient IP #1945

Merged
merged 3 commits into from
Jul 1, 2023
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 27, 2023

  • have a homogeneous design with the other providers
  • pass the linter
  • do go mod tidy
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
$ EFFICIENTIP_USERNAME="user" \
EFFICIENTIP_PASSWORD="secret" \
EFFICIENTIP_HOSTNAME="ipam.example.com" \
EFFICIENTIP_DNS_NAME="dns.smart" \
./dist/lego -m [email protected] --dns efficientip -d *.lego.example.com -d lego.example.com --dns.resolvers="1.1.1.1" -s https://acme-staging-v02.api.letsencrypt.org/directory run
2023/06/27 19:00:23 No key found for account [email protected]. Generating a P256 key.
2023/06/27 19:00:23 Saved key to /home/ldez/sources/go/src/github.com/go-acme/lego/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2023/06/27 19:00:23 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.3-September-21-2022.pdf
Do you accept the TOS? Y/n
y
2023/06/27 19:00:26 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!

Your account credentials have been saved in your Let's Encrypt
configuration directory at "./.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from Let's Encrypt so making regular
backups of this folder is ideal.
2023/06/27 19:00:26 [INFO] [*.lego.example.com, lego.example.com] acme: Obtaining bundled SAN certificate
2023/06/27 19:00:27 [INFO] [*.lego.example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/7069071614
2023/06/27 19:00:27 [INFO] [lego.example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/7069071624
2023/06/27 19:00:27 [INFO] [*.lego.example.com] acme: use dns-01 solver
2023/06/27 19:00:27 [INFO] [lego.example.com] acme: Could not find solver for: tls-alpn-01
2023/06/27 19:00:27 [INFO] [lego.example.com] acme: Could not find solver for: http-01
2023/06/27 19:00:27 [INFO] [lego.example.com] acme: use dns-01 solver
2023/06/27 19:00:27 [INFO] [*.lego.example.com] acme: Preparing to solve DNS-01
2023/06/27 19:00:27 [INFO] [lego.example.com] acme: Preparing to solve DNS-01
2023/06/27 19:00:27 [INFO] [*.lego.example.com] acme: Trying to solve DNS-01
2023/06/27 19:00:27 [INFO] [*.lego.example.com] acme: Checking DNS record propagation using [1.1.1.1:53]
2023/06/27 19:00:29 [INFO] Wait for propagation [timeout: 5m0s, interval: 2s]
2023/06/27 19:00:29 [INFO] [*.lego.example.com] acme: Waiting for DNS record propagation.
2023/06/27 19:00:31 [INFO] [*.lego.example.com] acme: Waiting for DNS record propagation.
2023/06/27 19:00:33 [INFO] [*.lego.example.com] acme: Waiting for DNS record propagation.
2023/06/27 19:00:42 [INFO] [*.lego.example.com] The server validated our request
2023/06/27 19:00:42 [INFO] [lego.example.com] acme: Trying to solve DNS-01
2023/06/27 19:00:42 [INFO] [lego.example.com] acme: Checking DNS record propagation using [1.1.1.1:53]
2023/06/27 19:00:44 [INFO] Wait for propagation [timeout: 5m0s, interval: 2s]
2023/06/27 19:00:47 [INFO] [lego.example.com] The server validated our request
2023/06/27 19:00:47 [INFO] [*.lego.example.com] acme: Cleaning DNS-01 challenge
2023/06/27 19:00:47 [INFO] [lego.example.com] acme: Cleaning DNS-01 challenge
2023/06/27 19:00:47 [INFO] [*.lego.example.com, lego.example.com] acme: Validations succeeded; requesting certificates
2023/06/27 19:00:48 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2023/06/27 19:00:49 [INFO] [*.lego.example.com] Server responded with a certificate.

Note the wildcard domain is important.

Closes #1921

@ldez ldez added this to the v4.13 milestone Jun 27, 2023
@ldez ldez requested a review from dmke June 27, 2023 17:12
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title feat: Add DNS provider for Efficient IP Add DNS provider for Efficient IP Jun 29, 2023
@ldez ldez merged commit b4a2913 into go-acme:master Jul 1, 2023
@ldez ldez deleted the feat/efficientip branch July 1, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for provider: Efficient IP
2 participants