Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #81

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Code review #81

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ba3ccb4
remove atlassian link
cuteolaf Nov 17, 2023
06a1f19
update readme
cuteolaf Nov 17, 2023
310bbbe
update runtime/lib.rs
cuteolaf Nov 17, 2023
7dd8515
remove atlassian link
cuteolaf Nov 17, 2023
a60ddb6
update readme
cuteolaf Nov 17, 2023
3da793f
update runtime/lib.rs
cuteolaf Nov 17, 2023
a5a5cad
fix testing/readme
cuteolaf Nov 17, 2023
350b3a7
Revert "remove atlassian link"
cuteolaf Nov 17, 2023
fac8db7
version up
cuteolaf Nov 17, 2023
a9a5fab
update readme: remove "generation and upstream" section
cuteolaf Nov 17, 2023
08b042b
Merge remote-tracking branch 'olaf/code-review' into code-review
cuteolaf Nov 17, 2023
2adf9ea
update max authorities, bump spec version
cuteolaf Nov 20, 2023
8005877
Merge branch 'dev' into code-review
cuteolaf Nov 20, 2023
e4175c3
Merge branch 'dev' into code-review
cuteolaf Dec 11, 2023
5df1d33
bump version to 3.9.3
cuteolaf Dec 11, 2023
9148b09
update max authorities
cuteolaf Dec 11, 2023
e0583b2
update cargo.toml version
cuteolaf Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .mega-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ DISABLE_LINTERS:
- BASH_SHFMT
- COPYPASTE_JSCPD
- REPOSITORY_GRYPE
# https://gluwa.atlassian.net/browse/CSUB-460
- REPOSITORY_TRIVY
- RUST_CLIPPY
- SPELL_CSPELL
Expand Down
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ A ready-to-use template generated this way is hosted for each Frontier release o
[substrate-developer-hub/frontier-node-template](https://github.com/substrate-developer-hub/frontier-node-template)
repository.

This template was originally forked from the
[Substrate Node Template](https://github.com/substrate-developer-hub/substrate-node-template). You
can find more information on features on this template there, and more detailed usage on the
[Substrate Developer Hub Tutorials](https://docs.substrate.io/tutorials/v3/) that use this heavily.

## Build & Run

To build the chain, execute the following commands from the project root:
Expand Down
5 changes: 1 addition & 4 deletions runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,6 @@ impl frame_system::Config for Runtime {
}

parameter_types! {
pub const MaxAuthorities: u32 = 100;

pub const ReportLongevity: u64 =
BondingDuration::get() as u64 * SessionsPerEra::get() as u64 * EpochDuration::get();
}
Expand Down Expand Up @@ -465,7 +463,7 @@ impl pallet_babe::Config for Runtime {
type EquivocationReportSystem =
pallet_babe::EquivocationReportSystem<Self, Offences, Historical, ReportLongevity>;
type WeightInfo = ();
type MaxAuthorities = MaxAuthorities;
type MaxAuthorities = ConstU32<100>;
type DisabledValidators = ();
type MaxNominators = ConstU32<100_000>; // TODO: revisit this
}
Expand Down Expand Up @@ -651,7 +649,6 @@ parameter_types! {
pub const MaxPending: u32 = 64;
pub const AnnouncementDepositBase: u128 = 500;
pub const AnnouncementDepositFactor: u128 = 500;

}

impl pallet_proxy::Config for Runtime {
Expand Down