Code review

[cuteolaf]

Code review

My first contribution to this project. (A simple code review to understand the project.)

---

Practical tips for PR review & merge:

• All GitHub Actions report PASS
• Newly added code/functions have unit tests
  • Coverage tools report all newly added lines as covered
  • The positive scenario is exercised
  • Negative scenarios are exercised, e.g. assert on all possible errors
  • Assert on events triggered if applicable
  • Assert on changes made to storage if applicable
• Modified behavior/functions - try to make sure above test items are covered
• Integration tests are added if applicable/needed

[cuteolaf]

@atodorov @nathanwhit

[atodorov]

Some changes requested. Also needs rebase onto latest dev b/c of some changes to README (should not conflict though).

[cuteolaf]

thanks for your review, @atodorov

[atodorov]

@cuteolaf can you rebase instead of merge and maybe squash some commits together for better readability.

Will requite another version bump afterwards.

Still needs decisionwhat the maximum number of authorities should be.

[atodorov]

See failure in https://github.com/gluwa/creditcoin3/actions/runs/7167525956/job/19514697597?pr=81.

Also can you 'rebase' instead of 'merge' ?