AI feedback disposable provider #4480
Open
+115
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eamodio There are 2 pull requests.
Please let me know if you think that creating such provider is unnecessary or if you suggest it should be improved. |
4 tasks
7 tasks
sergeibbb
force-pushed
the
4449-feedback-on-changelog
branch
from
4437459 to
8b7c748
Compare
sergeibbb
force-pushed
the
4449-feedback-provider
branch
from
5fc533a to
51f82c3
Compare
sergeibbb
force-pushed
the
4449-feedback-on-changelog
branch
from
8b7c748 to
5233993
Compare
sergeibbb
added a commit
that referenced
this pull request
Jul 9, 2025
Centralizes management of AI feedback context and changelog document URIs into a dedicated provider, improving modularity and cleanup. Updates relevant usages to access changelog feedback context through the new provider, removing redundant context management logic from command files. Simplifies resource cleanup on document close and ensures consistent context availability for AI-related features. (#4449, #4480)
sergeibbb
force-pushed
the
4449-feedback-provider
branch
from
51f82c3 to
e815a8e
Compare
sergeibbb
force-pushed
the
4449-feedback-on-changelog
branch
from
5233993 to
28c7ed5
Compare
Centralizes management of AI feedback context and changelog document URIs into a dedicated provider, improving modularity and cleanup. Updates relevant usages to access changelog feedback context through the new provider, removing redundant context management logic from command files. Simplifies resource cleanup on document close and ensures consistent context availability for AI-related features. (#4449, #4480)
sergeibbb
force-pushed
the
4449-feedback-provider
branch
from
e815a8e to
1f08c2d
Compare
sergeibbb
force-pushed
the
4449-feedback-provider
branch
from
1f08c2d to
f851fe3
Compare
There was a problem hiding this comment.
I'm having a hard time parsing the need for this between all of the linked issues and PRs, nor do I know how to test it, so I will defer to @eamodio 's review on this one, unless you can give me a full rundown/explanation as someone who hasn't been involved with this work @sergeibbb .
|
I just thought that since the implementation is stateful it might be worth to attach it to the container as a stateful class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up of #4449 and #4479
It wraps static ai-feedback related values to a disposable provided linked to the container.
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses