Moves AI feedback URI state handling to provider

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449)

Author: sergeibbb

src/commands/aiFeedback.ts

@@ -6,11 +6,7 @@ import type { AIResultContext } from '../plus/ai/aiProviderService';
 import { extractAIResultContext } from '../plus/ai/utils/-webview/ai.utils';
 import type { QuickPickItemOfT } from '../quickpicks/items/common';
 import { command } from '../system/-webview/command';
-import { setContext } from '../system/-webview/context';
-import { UriMap } from '../system/-webview/uriMap';
-import type { Deferrable } from '../system/function/debounce';
-import { debounce } from '../system/function/debounce';
-import { filterMap, map } from '../system/iterable';
+import { map } from '../system/iterable';
 import { Logger } from '../system/logger';
 import { ActiveEditorCommand } from './commandBase';
 import { getCommandUri } from './commandBase.utils';
@@ -45,32 +41,20 @@ export class AIFeedbackUnhelpfulCommand extends ActiveEditorCommand {
 
 type UnhelpfulResult = { reasons?: AIFeedbackUnhelpfulReasons[]; custom?: string };
 
-const uriResponses = new UriMap<AIFeedbackEvent['sentiment']>();
-let _updateContextDebounced: Deferrable<() => void> | undefined;
-
 async function sendFeedback(container: Container, uri: Uri, sentiment: AIFeedbackEvent['sentiment']): Promise<void> {
 	const context = extractAIResultContext(container, uri);
 	if (!context) return;
 
 	try {
-		const previous = uriResponses.get(uri);
+		const previous = container.aiFeedback.getFeedbackResponse(uri);
 		if (sentiment === previous) return;
 
 		let unhelpful: UnhelpfulResult | undefined;
 		if (sentiment === 'unhelpful') {
 			unhelpful = await showUnhelpfulFeedbackPicker();
 		}
 
-		uriResponses.set(uri, sentiment);
-		_updateContextDebounced ??= debounce(() => {
-			void setContext('gitlens:tabs:ai:helpful', [
-				...filterMap(uriResponses, ([uri, sentiment]) => (sentiment === 'helpful' ? uri : undefined)),
-			]);
-			void setContext('gitlens:tabs:ai:unhelpful', [
-				...filterMap(uriResponses, ([uri, sentiment]) => (sentiment === 'unhelpful' ? uri : undefined)),
-			]);
-		}, 100);
-		_updateContextDebounced();
+		container.aiFeedback.setFeedbackResponse(uri, sentiment);
 
 		sendFeedbackEvent(container, { source: 'ai:markdown-preview' }, context, sentiment, unhelpful);
 	} catch (ex) {

src/telemetry/aiFeedbackProvider.ts

@@ -1,9 +1,12 @@
 import type { Disposable, Uri } from 'vscode';
 import { workspace } from 'vscode';
+import type { AIFeedbackEvent } from '../constants.telemetry';
 import type { AIResultContext } from '../plus/ai/aiProviderService';
 import { setContext } from '../system/-webview/context';
+import { UriMap } from '../system/-webview/uriMap';
 import type { Deferrable } from '../system/function/debounce';
 import { debounce } from '../system/function/debounce';
+import { filterMap } from '../system/iterable';
 
 export class AIFeedbackProvider implements Disposable {
 	constructor() {
@@ -26,8 +29,10 @@ export class AIFeedbackProvider implements Disposable {
 	private readonly _disposables: Disposable[] = [];
 	dispose(): void {
 		this._disposables.forEach(d => void d.dispose());
+		this._uriResponses.clear();
 		this._changelogFeedbacks.clear();
 		this._changelogUris.clear();
+		this._updateFeedbackContextDebounced = undefined;
 		this._updateChangelogContextDebounced = undefined;
 	}
 
@@ -64,4 +69,29 @@ export class AIFeedbackProvider implements Disposable {
 	private deleteChangelogFeedback(documentUri: string): void {
 		this._changelogFeedbacks.delete(documentUri);
 	}
+
+	// Storage for AI feedback responses by URI
+	private readonly _uriResponses = new UriMap<AIFeedbackEvent['sentiment']>();
+	private _updateFeedbackContextDebounced: Deferrable<() => void> | undefined;
+	private updateFeedbackContext(): void {
+		this._updateFeedbackContextDebounced ??= debounce(() => {
+			void setContext('gitlens:tabs:ai:helpful', [
+				...filterMap(this._uriResponses, ([uri, sentiment]) => (sentiment === 'helpful' ? uri : undefined)),
+			]);
+			void setContext('gitlens:tabs:ai:unhelpful', [
+				...filterMap(this._uriResponses, ([uri, sentiment]) => (sentiment === 'unhelpful' ? uri : undefined)),
+			]);
+		}, 100);
+		this._updateFeedbackContextDebounced();
+	}
+	setFeedbackResponse(uri: Uri, sentiment: AIFeedbackEvent['sentiment']): void {
+		const previous = this._uriResponses.get(uri);
+		if (sentiment === previous) return;
+
+		this._uriResponses.set(uri, sentiment);
+		this.updateFeedbackContext();
+	}
+	getFeedbackResponse(uri: Uri): AIFeedbackEvent['sentiment'] | undefined {
+		return this._uriResponses.get(uri);
+	}
 }