Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kpp standalone #69

Open
wants to merge 1 commit into
base: dev/no-diff-to-benchmark
Choose a base branch
from

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Oct 9, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This is the companion PR to geoschem/geos-chem#2483. We have added code to the src/CMakeLists.txt file to build the KPP standalone executable when compiling GEOS-Chem with the fullchem mechanism (-DMECH=fullchem) or the custom mechanism (-DMECH=custom).

Expected changes

The KPP standalone executable file will be built and copied to the GEOS-Chem run directory.

Related Github Issue

src/CMakeLists.txt
- Added code to build and install the KPP standalone executable
  when compiling GEOS-Chem with either "-DMECH=fullchem" (default)
  or "-DMECH=custom" options.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added category: Feature Request New feature or request topic: Build Related to CMake and/or the build sequence labels Oct 9, 2024
@yantosca yantosca added this to the 14.6.0 milestone Oct 9, 2024
@yantosca yantosca requested a review from lizziel October 9, 2024 15:54
@yantosca yantosca self-assigned this Oct 9, 2024
@lizziel lizziel changed the base branch from main to dev/no-diff-to-benchmark October 9, 2024 17:39
Copy link
Contributor

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Build Related to CMake and/or the build sequence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants