Add constant mode settings to Amg_data #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Jan 31, 2025
gassmoeller
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Yes, this looks like a clear bug fix. Can you also add a changelog entry that makes clear we now use the constant modes in the melt solver, just to make users aware results may change?
Do I see this correctly that this change generally reduces the number of iterations in tests, but in some cases increases them?
source/simulator/assembly.cc
Outdated
| @@ -525,6 +525,7 @@ namespace aspect | |||
|
|
|||
| Amg_data.smoother_sweeps = 2; | |||
| Amg_data.coarse_type = "symmetric Gauss-Seidel"; | |||
| Amg_data.constant_modes=constant_modes; | |||
There was a problem hiding this comment.
Sorry to nitpick, but just to keep our code style here consistent, please make this into:
Suggested change
| Amg_data.constant_modes=constant_modes; | |
| Amg_data.constant_modes = constant_modes; |
quangx
force-pushed
the
constant_modes
branch
from
a4cfff8 to
f1405fc
Compare
gassmoeller
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue in which constant_mode is created but not used.
#6221
@tjhei