Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melt transport AMG constant mode settings are never used #6221

Closed
tjhei opened this issue Jan 30, 2025 · 1 comment
Closed

melt transport AMG constant mode settings are never used #6221

tjhei opened this issue Jan 30, 2025 · 1 comment
Labels

Comments

@tjhei
Copy link
Member

tjhei commented Jan 30, 2025

While looking at the code with @quangx we discovered that the forgot to use the AMG setting for constant_modes is computed but never used, see

std::vector<std::vector<bool>> constant_modes;
dealii::ComponentMask cm_pressure = introspection.component_masks.pressure;
if (parameters.include_melt_transport)
cm_pressure = cm_pressure | introspection.variable("compaction pressure").component_mask;
DoFTools::extract_constant_modes (dof_handler,
cm_pressure,
constant_modes);
Amg_data.elliptic = true;
Amg_data.higher_order_elements = false;
Amg_data.smoother_sweeps = 2;
Amg_data.coarse_type = "symmetric Gauss-Seidel";
LinearAlgebra::PreconditionAMG *Mp_preconditioner_AMG
= dynamic_cast<LinearAlgebra::PreconditionAMG *> (Mp_preconditioner.get());
Mp_preconditioner_AMG->initialize (system_preconditioner_matrix.block(1,1), Amg_data);

@quangx can you please prepare a PR to fix this so we can see the impact?

@gassmoeller
Copy link
Member

Fixed by #6222.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants