Fix set_simulation_state STOPPED timeout - #950
Open
nekomario28 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
Exercise PLAYING and PAUSED transitions to STOPPED and repeated STOPPED requests through the public simulation interfaces. Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
The expanded regression tried to classify PAUSED immediately after a STOPPED reset, but GetSimulationState intentionally reports paused iteration-zero worlds as STOPPED. Restore the previously validated PLAYING -> STOPPED regression instead of encoding an invalid state transition assumption. Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
Bring the branch ancestry up to upstream ros2 at 2ee8a5c without rewriting the existing fix history. The merge tree matches the clean merge computed for upstream PR gazebosim#950. Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
Author
|
@ahcorde The upstream ROS2 CI is still |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #919
Summary
Fix
SetSimulationState(STOPPED)reporting a timeout even when Gazebo has already reset the simulation.The reset completion detector is armed before issuing the asynchronous reset request, so completion cannot be lost before the wait begins.
The STOPPED transition is handled in phases:
pausedwith iteration zero).The pause-preservation compatibility handling for released gz-sim versions is intentionally retained.
Test coverage
get_simulation_stateis used as the semantic oracle.Backport policy
I am not sure; maintainer guidance is welcome.
Assisted-by: ChatGPT (GPT-5.6 Sol)