Fix set_simulation_state STOPPED timeout - #10
Draft
nekomario28 wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
This was referenced Aug 21, 2026
nekomario28
force-pushed
the
fix/919-upstream-final
branch
from
August 21, 2026 13:01
8aeb872 to
ff088e9
Compare
Exercise PLAYING and PAUSED transitions to STOPPED and repeated STOPPED requests through the public simulation interfaces. Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
The expanded regression tried to classify PAUSED immediately after a STOPPED reset, but GetSimulationState intentionally reports paused iteration-zero worlds as STOPPED. Restore the previously validated PLAYING -> STOPPED regression instead of encoding an invalid state transition assumption. Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
Bring the branch ancestry up to upstream ros2 at 2ee8a5c without rewriting the existing fix history. The merge tree matches the clean merge computed for upstream PR gazebosim#950. Signed-off-by: Yuu <206304251+nekomario28@users.noreply.github.com> Assisted-by: ChatGPT (GPT-5.6 Sol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-local evidence carrier for upstream gazebosim#950 / issue gazebosim#919. Do not merge this fork PR.
Current base: upstream-aligned
ros2at2ee8a5c716d1838de0b7ac817638ad5e9304955e.Current head:
2e830dd25172f1a066c04ff85e79cf8389cf91b7.Scope
ResetSimulationuse the same arm -> request -> wait contract;paused && iterations == 0;The attempted PAUSED -> STOPPED / repeated STOPPED -> STOPPED expansion was reverted because the fixture incorrectly expected PAUSED immediately after a STOPPED reset, while the public classifier still reports STOPPED for
paused && iterations == 0.Validation
Current-tree fork ROS2 CI run
32841870243:97782959967)ros_gz CI (ubuntu:resolute, rolling)Build and Test: PASS (job97782959680)The run event is
pull_request. Its synthetic merge tree is identical to the current head tree, so this is current-tree validation; it should not be described as exact-head-commit execution.Earlier Jazzy / Gazebo Harmonic (
gz-sim8) minimized candidate, run32483225071/ job96773957402:Earlier subtractive evidence:
Timed out while trying to stop simulation(32470884388/96737207002);32479212955/96761787242).Backport
The bug was reproduced and fixed on ROS 2 Jazzy + Gazebo Harmonic / gz-sim8, so a Jazzy backport remains justified after the mainline change is accepted.
GenAI assistance is disclosed in commit trailers with
Assisted-by: ChatGPT (GPT-5.6 Sol).