Add an explicit dependency on cppzmq-dev #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Jammy, the zmq C++ headers were included in libzmq-dev. However, in Noble, the headers are now in a separate package, `cppzmq-dev`, and that package is recommended by libzmq-dev. This shouldn't affect most users, but anywhere these dependencies are installed with `--no-install-recommends` will now break because it won't have cppzmq-dev installed. This patch just adds an explicit dependency to avoid the problem. Signed-off-by: Addisu Z. Taddese <[email protected]>
mjcarroll
approved these changes
Aug 2, 2024
|
I think this needs to be done in a separate |
Signed-off-by: Addisu Z. Taddese <[email protected]>
Done in 0135bfb. We should be replacing all the Jammy CI jobs with Noble, but we were having issues with running the code coverage tools in gazebosim/gz-fuel-tools#427 |
iche033
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
In Jammy, the zmq C++ headers were included in libzmq-dev. However, in Noble, the headers are now in a separate package,
cppzmq-dev, and that package is recommended by libzmq-dev. This shouldn't affect most users, but anywhere these dependencies are installed with--no-install-recommendswill now break because it won't have cppzmq-dev installed. This patch just adds an explicit dependency to avoid the problem.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.