Simplify scoped name tracking - #121
Merged
Merged
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
10 tasks
Contributor
|
LGTM, thanks! |
azeey
pushed a commit
that referenced
this pull request
Feb 17, 2026
* Support nested models in sdformat -> mjcf conversion Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Remove leftover comment Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Fix typo Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Handle nested parent link for fixed joint Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Improve local var name Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Simplify scoped name tracking (#121) * Simplify scoped name tracking Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Fix style Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> --------- Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions for #119