Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ign_TEST #420

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Fix ign_TEST #420

merged 4 commits into from
Jun 17, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jun 16, 2022

🦟 Bug fix

Related to

Summary

I merged #392 without noticing that there was a new Windows test failure. That's why the check requirements are so important 😅

Disabled the new test on Windows, and removed just the offending expectation on the list test. I re-enabled it on all platforms just to see how it goes, then I may disable it for macOS and/or Windows as needed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added tests Broken or missing tests / testing infra Windows Windows support labels Jun 16, 2022
@chapulina chapulina requested a review from Blast545 June 16, 2022 16:51
@chapulina chapulina requested a review from jennuine as a code owner June 16, 2022 16:51
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 16, 2022
@Blast545 Blast545 mentioned this pull request Jun 16, 2022
8 tasks
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #420 (9e00512) into ign-gui3 (6c83500) will increase coverage by 0.65%.
The diff coverage is n/a.

❗ Current head 9e00512 differs from pull request most recent head 5f442ae. Consider uploading reports for the commit 5f442ae to get more accurate results

@@             Coverage Diff              @@
##           ign-gui3     #420      +/-   ##
============================================
+ Coverage     65.45%   66.10%   +0.65%     
============================================
  Files            29       29              
  Lines          3216     3216              
============================================
+ Hits           2105     2126      +21     
+ Misses         1111     1090      -21     
Impacted Files Coverage Δ
src/ign.cc 44.68% <0.00%> (+44.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c83500...5f442ae. Read the comment docs.

Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

src/ign_TEST.cc Outdated Show resolved Hide resolved
src/ign_TEST.cc Show resolved Hide resolved
@chapulina chapulina merged commit 9b27bec into ign-gui3 Jun 17, 2022
@chapulina chapulina deleted the chapulina/3/ign_TEST branch June 17, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel tests Broken or missing tests / testing infra Windows Windows support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants