Skip to content

Commit

Permalink
Fix ign_TEST (#420)
Browse files Browse the repository at this point in the history
Signed-off-by: Louise Poubel <[email protected]>
  • Loading branch information
chapulina authored Jun 17, 2022
1 parent 6c83500 commit 9b27bec
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions src/ign_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ class CmdLine : public ::testing::Test
};

// See https://github.com/ignitionrobotics/ign-gui/issues/75
// See https://github.com/gazebosim/gz-gui/issues/415
TEST_F(CmdLine, DETAIL_IGN_UTILS_ADD_DISABLED_PREFIX(list))
TEST_F(CmdLine, IGN_UTILS_TEST_ENABLED_ONLY_ON_LINUX(list))
{
// Clear home if it exists
common::removeAll(this->kFakeHome);

EXPECT_FALSE(common::exists(this->kFakeHome));
// This line is flaky, see https://github.com/gazebosim/gz-gui/issues/415
// EXPECT_FALSE(common::exists(this->kFakeHome));

std::string output = custom_exec_str("ign gui -l");
EXPECT_NE(output.find("TopicEcho"), std::string::npos) << output;
Expand All @@ -104,7 +104,8 @@ TEST_F(CmdLine, DETAIL_IGN_UTILS_ADD_DISABLED_PREFIX(list))

//////////////////////////////////////////////////
/// \brief Check --help message and bash completion script for consistent flags
TEST(ignTest, GuiHelpVsCompletionFlags)
// See https://github.com/gazebo-tooling/release-tools/issues/398
TEST(ignTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(GuiHelpVsCompletionFlags))
{
// Flags in help message
std::string helpOutput = custom_exec_str(kIgnCommand + " gui --help");
Expand All @@ -126,7 +127,7 @@ TEST(ignTest, GuiHelpVsCompletionFlags)
EXPECT_GT(flags.size(), 0u);

// Match each flag in script output with help message
for (std::string flag : flags)
for (const auto &flag : flags)
{
EXPECT_NE(std::string::npos, helpOutput.find(flag)) << helpOutput;
}
Expand Down

0 comments on commit 9b27bec

Please sign in to comment.