Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc with respect to update behaviour #1061

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −0
Open

Update doc with respect to update behaviour #1061

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15b0f75
Update doc with respect to update behaviour
AndreasBurger Jan 15, 2025
d4cf901
address initial (offline) comments
AndreasBurger Jan 17, 2025
dfcbe51
address comment
AndreasBurger Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/operations/operations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,3 +226,14 @@ One of the benefits of having managed service principals is that the operator co

After the service principal secret has been rotated and the corresponding secret is updated, all Shoot clusters using it need to be reconciled or the last operation to be retried.

### Rolling Update Triggers

Changes to the `Shoot` worker-pools are applied in-place where possible. In case this is not possible a rolling update of the workers will be performed to apply the new configuration, as outlined in [the Gardener documentation](https://github.com/gardener/gardener/blob/master/docs/usage/shoot-operations/shoot_updates.md#in-place-vs-rolling-updates). The exact fields that trigger this behaviour depend on whether the feature gate `NewWorkerPoolHash` is enabled. If it is not enabled, the fields mentioned in the [Gardener doc](https://github.com/gardener/gardener/blob/master/docs/usage/shoot-operations/shoot_updates.md#rolling-update-triggers) are used, with a few additions:

- `.spec.provider.infrastructureConfig.identity`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking not complete. There are still some calculated values I need to understand (again) in order to add a mention to them.

Copy link
Contributor

@kon-angelo kon-angelo Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will give the suggestion to have a line per sentence. While the produced output still concatenates these into a single paragraph, it is easier to review with the line per sentence.

- `.spec.provider.workers[].dataVolumes[].size` (only the affected worker pool)
- `.spec.provider.workers[].dataVolumes[].type` (only the affected worker pool)

If the feature gate _is_ enabled, instead of the complete provider config only the fields explicitly mentioned above are used, with the addition of

- `.spec.provider.workers[].providerConfig.diagnosticsProfile`
Loading