Update doc with respect to update behaviour #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/documentation
gardener-robot-ci-3
added
the
reviewed/ok-to-test
AndreasBurger
commented
Jan 15, 2025
| Changes to the `Shoot` worker-pools are applied in-place where possible. In case this is not possible a rolling update of the workers will be performed to apply the new configuration, as outlined in [the Gardener documentation](https://github.com/gardener/gardener/blob/master/docs/usage/shoot-operations/shoot_updates.md#in-place-vs-rolling-updates). The exact fields that trigger this behaviour depend on whether the feature gate `NewWorkerPoolHash` is enabled. If it is not enabled, the fields mentioned in the [Gardener doc](https://github.com/gardener/gardener/blob/master/docs/usage/shoot-operations/shoot_updates.md#rolling-update-triggers) are used, with a few additions: | ||
|
|
||
| - `.spec.provider.workers[].dataVolumes[].size` and `.spec.provider.workers[].dataVolumes[].type` (only the affected worker pool) | ||
| - `.spec.provider.infrastructureConfig.identity` |
There was a problem hiding this comment.
Strictly speaking not complete. There are still some calculated values I need to understand (again) in order to add a mention to them.
There was a problem hiding this comment.
I will give the suggestion to have a line per sentence. While the produced output still concatenates these into a single paragraph, it is easier to review with the line per sentence.
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
AndreasBurger
force-pushed
the
update-hash-doc
branch
from
18fa5e3 to
dfcbe51
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area documentation
/kind enhancement
/platform azure
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: