Promote UseEtcdWrapper feature gate to GA
#936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
size/l
gardener-robot-ci-1
added
needs/ok-to-test
shreyas-s-rao
added a commit
to shreyas-s-rao/ci-infra
that referenced
this pull request
Nov 26, 2024
…rapper is promoted to GA by gardener/etcd-druid#936
|
I have also raised gardener/ci-infra#2757 to remove the prow job for e2e test for nondistroless version of etcd (ie, etcd-custom-image), since that is no longer supported now that the feature gate has been promoted to GA. |
|
@shreyas-s-rao please rebase this PR as |
shreyas-s-rao
force-pushed
the
feature/use-etcd-wrapper-ga
branch
from
f769004 to
39123c7
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
3 tasks
|
@ishan16696 rebased as requested. Although, I would want to wait for #812 to be merged before rebasing this PR again and then merging. I don't want @anveshreddy18 to go through yet another round of rebasing on his PR. Until I rebase on the configmap changes, the tests here will continue to fail, so these test failures can be ignored for the timebeing. |
seshachalam-yv
approved these changes
Nov 26, 2024
shreyas-s-rao
force-pushed
the
feature/use-etcd-wrapper-ga
branch
from
39123c7 to
39cff9d
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
seshachalam-yv
approved these changes
Nov 26, 2024
|
/lgtm |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
2 tasks
gardener-prow bot
pushed a commit
to gardener/ci-infra
that referenced
this pull request
Nov 27, 2024
…rapper is promoted to GA by gardener/etcd-druid#936 (#2757)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality open-source usability
/kind task
What this PR does / why we need it:
The feature gate
UseEtcdWrapperhas now been promoted to GA, and locked to true. The related code has been cleaned up. The feature gate will finally be removed in #935 .Which issue(s) this PR fixes:
Fixes partially #776
Special notes for your reviewer:
/assign @seshachalam-yv @ishan16696
/cc @unmarshall @aaronfern
Release note: