-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove etcd-druid nondistroless prow job #2757
Remove etcd-druid nondistroless prow job #2757
Conversation
…rapper is promoted to GA by gardener/etcd-druid#936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
@ishan16696: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@plkokanov @rfranzke PTAL. Not urgent, but would be nice to get rid of the now unnecessary prow job, since the feature gate on druid is moving to GA via gardener/etcd-druid#936 |
/lgtm |
LGTM label has been added. Git tree hash: ee59af26b9047e42f36bc20bd42cf0b3e84aa6ad
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ishan16696, shafeeqes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup |
@shreyas-s-rao: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Remove etcd-druid nondistroless prow job, since feature gate UseEtcdWrapper is promoted to GA by gardener/etcd-druid#936.
Which issue(s) this PR fixes:
Fixes partially gardener/etcd-druid#776
Special notes for your reviewer:
@oliver-goetz I am unaware of the prow job manifests under https://github.com/gardener/ci-infra/tree/master/config/jobs/etcd-druid/releases. Are these used only for running prow jobs against older release branches? If that's the case, I'm assuming I need not change them in this PR, correct? Please let me know.