Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove etcd-druid nondistroless prow job #2757

Merged

Conversation

shreyas-s-rao
Copy link
Contributor

What this PR does / why we need it:
Remove etcd-druid nondistroless prow job, since feature gate UseEtcdWrapper is promoted to GA by gardener/etcd-druid#936.

Which issue(s) this PR fixes:
Fixes partially gardener/etcd-druid#776

Special notes for your reviewer:
@oliver-goetz I am unaware of the prow job manifests under https://github.com/gardener/ci-infra/tree/master/config/jobs/etcd-druid/releases. Are these used only for running prow jobs against older release branches? If that's the case, I'm assuming I need not change them in this PR, correct? Please let me know.

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link

gardener-prow bot commented Nov 26, 2024

@ishan16696: changing LGTM is restricted to collaborators

In response to this:

LGTM!!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shreyas-s-rao
Copy link
Contributor Author

@plkokanov @rfranzke PTAL. Not urgent, but would be nice to get rid of the now unnecessary prow job, since the feature gate on druid is moving to GA via gardener/etcd-druid#936

@shafeeqes
Copy link
Contributor

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
Copy link

gardener-prow bot commented Nov 27, 2024

LGTM label has been added.

Git tree hash: ee59af26b9047e42f36bc20bd42cf0b3e84aa6ad

Copy link

gardener-prow bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ishan16696, shafeeqes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@shafeeqes
Copy link
Contributor

/kind cleanup

@gardener-prow gardener-prow bot added kind/cleanup Something that is not needed anymore and can be cleaned up and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 27, 2024
@gardener-prow gardener-prow bot merged commit b4fc763 into gardener:master Nov 27, 2024
7 checks passed
Copy link

gardener-prow bot commented Nov 27, 2024

@shreyas-s-rao: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key etcd-druid-e2e-kind-nondistroless-etcd.yaml using file ``

In response to this:

What this PR does / why we need it:
Remove etcd-druid nondistroless prow job, since feature gate UseEtcdWrapper is promoted to GA by gardener/etcd-druid#936.

Which issue(s) this PR fixes:
Fixes partially gardener/etcd-druid#776

Special notes for your reviewer:
@oliver-goetz I am unaware of the prow job manifests under https://github.com/gardener/ci-infra/tree/master/config/jobs/etcd-druid/releases. Are these used only for running prow jobs against older release branches? If that's the case, I'm assuming I need not change them in this PR, correct? Please let me know.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shreyas-s-rao shreyas-s-rao deleted the cleanup/etcd-wrapper-ga branch November 27, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants