Skip to content

New tool: TSENAT v.0.99.0#7916

Open
gallardoalba wants to merge 31 commits into
galaxyproject:mainfrom
gallardoalba:Add_TSENAT
Open

New tool: TSENAT v.0.99.0#7916
gallardoalba wants to merge 31 commits into
galaxyproject:mainfrom
gallardoalba:Add_TSENAT

Conversation

@gallardoalba
Copy link
Copy Markdown
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@gallardoalba
Copy link
Copy Markdown
Contributor Author

Hi @bernt-matthias, could you have a look when you have time at the problem? The tool is working in the Galaxy interface, but test are failing, and I am not sure why. Thanks a lot.

@gallardoalba gallardoalba marked this pull request as ready for review May 9, 2026 13:58
@bernt-matthias
Copy link
Copy Markdown
Contributor

Hi @bernt-matthias, could you have a look when you have time at the problem? The tool is working in the Galaxy interface, but test are failing, and I am not sure why. Thanks a lot.

The test failures seem pretty clear, or: https://github.com/galaxyproject/tools-iuc/actions/runs/25609719519?pr=7916 ?

  • The first test produces different output than exprected: Expected 1+-0 occurences of 'gene_id' in output
  • Test 2-8 Error message: [build_analysis] Sample name mismatch between Salmon folder and metadata:

Comment thread tools/tsenat/macros.xml Outdated
Comment thread tools/tsenat/tsenat.R
Comment thread tools/tsenat/tsenat.xml Outdated
Comment thread tools/tsenat/tsenat.xml Outdated
Comment thread tools/tsenat/tsenat.xml Outdated
Comment thread tools/tsenat/tsenat.xml Outdated
Comment thread tools/tsenat/tsenat.xml Outdated
Comment thread tools/tsenat/tsenat.xml
@gallardoalba
Copy link
Copy Markdown
Contributor Author

Hi @bernt-matthias, could you have a look when you have time at the problem? The tool is working in the Galaxy interface, but test are failing, and I am not sure why. Thanks a lot.

The test failures seem pretty clear, or: https://github.com/galaxyproject/tools-iuc/actions/runs/25609719519?pr=7916 ?

* The first test produces different output than exprected: `Expected 1+-0 occurences of 'gene_id' in output`

* Test 2-8 `Error message: [build_analysis] Sample name mismatch between Salmon folder and metadata:`

Thank you, I do not work in Galaxy wrappers for a long time and forgot how to check it.

Copy link
Copy Markdown
Contributor

@SaimMomin12 SaimMomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion from my side

Comment thread tools/tsenat/macros.xml Outdated
Co-authored-by: Saim Momin <64724322+SaimMomin12@users.noreply.github.com>
@gallardoalba
Copy link
Copy Markdown
Contributor Author

Hi! Do you think it could be merged? @bernt-matthias @SaimMomin12. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants