-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove pysam and bwa warmup hack #65
Conversation
def close(self) -> None: | ||
self._reader.close() | ||
super().close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we no longer need to override this method, it should have conformed to the same shape as the superclass:
def close(self) -> bool:
self._reader.close()
return super().close()
@@ -33,7 +33,7 @@ | |||
>>> bwa.map_all(queries=[query]) | |||
[BwaResult(query=Query(id='NA', bases='AAAAAA'), hit_count=3968, hits=[])] | |||
>>> bwa.close() | |||
|
|||
True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 97.38% 97.25% -0.13%
==========================================
Files 25 25
Lines 1605 1603 -2
Branches 302 303 +1
==========================================
- Hits 1563 1559 -4
Misses 23 23
- Partials 19 21 +2 ☔ View full report in Codecov by Sentry. |
8d4f9d6
to
dbcd145
Compare
I have one strangely failing test on GitHub CI (but not locally):
Will debug... EDIT: the issue is we were using the old bwa repo in FG's org. |
It is mentioned
pysam.AlignmentFile
internally buffers stdin so a hack was devised to "warm it up".However,
fgpyo.sam.reader
andpysam.AlignmentFile
are not needed and only provide code indirection since we can build the SAM header and all subsequent records using thefrom_text()
/fromstring()
methods of each.