Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG images sometimes don't have a '.svg' extension #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SVG images sometimes don't have a '.svg' extension #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const isNode = selector => selector && selector.nodeType === 1

export const isSvg = image => {
const source = image.currentSrc || image.src
return source.substr(-4).toLowerCase() === '.svg'
return source.toLowerCase().endsWith(".svg") || source.toLowerCase().includes("/svg/")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we check for "/svg/"? This is not standard.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes the type definition is a url parameter and not the file extension
Ex
SVG file: http://www.plantuml.com/plantuml/svg/SoWkIImgAStDuNBCoKnELT2rKt3AJx9IS2mjoKZDAybCJYp9pCzJ24ejB4qjBk5oICrB0Ie60000

PNG file: http://www.plantuml.com/plantuml/png/SoWkIImgAStDuNBCoKnELT2rKt3AJx9IS2mjoKZDAybCJYp9pCzJ24ejB4qjBk5oICrB0Ie60000

}

export const getImagesFromSelector = selector => {
Expand Down