SVG images sometimes don't have a '.svg' extension #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4708841:
|
| @@ -7,7 +7,7 @@ export const isNode = selector => selector && selector.nodeType === 1 | |||
|
|
|||
| export const isSvg = image => { | |||
| const source = image.currentSrc || image.src | |||
| return source.substr(-4).toLowerCase() === '.svg' | |||
| return source.toLowerCase().endsWith(".svg") || source.toLowerCase().includes("/svg/") | |||
There was a problem hiding this comment.
Why should we check for "/svg/"? This is not standard.
There was a problem hiding this comment.
Sometimes the type definition is a url parameter and not the file extension
Ex
SVG file: http://www.plantuml.com/plantuml/svg/SoWkIImgAStDuNBCoKnELT2rKt3AJx9IS2mjoKZDAybCJYp9pCzJ24ejB4qjBk5oICrB0Ie60000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SVG url test only verify '.svg'. See #190
Result
test '/svg/' too