Skip to content

Settings screen #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2021
Merged

Settings screen #57

merged 3 commits into from
May 21, 2021

Conversation

fichek
Copy link
Member

@fichek fichek commented May 20, 2021

settings.mp4
  • Resolves Settings Panel #28 by adding a settings screen
  • Added an auto-hiding floating settings button on the main screen to show the settings
  • Added several new strings so localization update is needed, see Localization update #61
  • Added closer color variants to colors.xml and updated themes xml files with new colors, removed unused ones
  • Removed the splash screen background as it was causing issues with the settings screen, need to fix that, see Fix the splash screen #62
  • Removed hiding/showing watermark on tap since that is now used to hide/show settings button, instead you can now permanently hide/show the watermark from settings

@fichek fichek added the enhancement New feature or request label May 20, 2021
@fichek fichek force-pushed the feature/28-settings branch from 765070c to 25ab31c Compare May 21, 2021 02:59
This was referenced May 21, 2021
@fichek fichek force-pushed the feature/28-settings branch from 25ab31c to dd4eee4 Compare May 21, 2021 03:19
@fichek fichek marked this pull request as ready for review May 21, 2021 03:20
@fichek fichek linked an issue May 21, 2021 that may be closed by this pull request
@fichek fichek force-pushed the feature/28-settings branch 2 times, most recently from 8e62561 to e01a35b Compare May 21, 2021 04:59
@fichek fichek requested a review from jlucidar May 21, 2021 05:00
@SanielDous
Copy link

When the Tutorial is merged we should add the link from the settings to the TutorialActivity so user can display it again (if they want to)

@fichek
Copy link
Member Author

fichek commented May 21, 2021

When the Tutorial is merged we should add the link from the settings to the TutorialActivity so user can display it again (if they want to)

Absolutely, will add any new stuff in separate PRs, or you can add it yourself in your PR if this is merged before.

@fichek fichek force-pushed the feature/28-settings branch from e01a35b to 38adfba Compare May 21, 2021 15:20
@jlucidar jlucidar added this to the BETA version milestone May 21, 2021
@jlucidar jlucidar merged commit 6fbd2ea into dev May 21, 2021
@fichek fichek deleted the feature/28-settings branch May 21, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings Panel
3 participants