Skip to content

Localization update #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fichek opened this issue May 21, 2021 · 5 comments · Fixed by #64, #65, #67, #69 or #71
Closed

Localization update #61

fichek opened this issue May 21, 2021 · 5 comments · Fixed by #64, #65, #67, #69 or #71
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
BETA version

Comments

@fichek
Copy link
Member

fichek commented May 21, 2021 •
edited
Loading

PRs #57 and #63 introduce new UI strings that need to be translated to existing languages (German, Spanish, French and Chinese).
@fichek fichek added help wanted Extra attention is needed good first issue Good for newcomers labels May 21, 2021
@fichek fichek mentioned this issue May 21, 2021
Merged
@fichek fichek added this to the BETA version milestone May 21, 2021
@fichek
Copy link
Member Author

fichek commented May 21, 2021

I can help with German translation

Cool, thanks, do you know how to work with strings xml files and test them? You can ping me on Discord if you need any help (same username).

@Guili123
Copy link

I can help with German translation

Cool, thanks, do you know how to work with strings xml files and test them? You can ping me on Discord if you need any help (same username).

Already send you an message on Discord

@fichek fichek linked a pull request May 21, 2021 that will close this issue
updated german translations #64
Merged
@jlucidar jlucidar mentioned this issue May 21, 2021
Merged
@jlucidar jlucidar linked a pull request May 21, 2021 that will close this issue
add Portuguese translations. Courtesy of Coltro on Discord :) #65
Merged
@jlucidar jlucidar mentioned this issue May 22, 2021
Merged
This was linked to pull requests May 22, 2021
add Spanish translations. Courtesy of eduardoavdr on Discord :) #67
Merged
Update Chinese translation #69
Merged
Update Chinese translation per request #71
Merged
@fichek
Copy link
Member Author

fichek commented May 24, 2021

There’s currently just one string left untranslated in the dev branch: <string name="video_preset_legacy_buffered">Legacy Buffered</string> , anyone wanna take care of that so we can close this issue?

@jlucidar
Copy link
Member

There’s currently just one string left untranslated in the dev branch: <string name="video_preset_legacy_buffered">Legacy Buffered</string> , anyone wanna take care of that so we can close this issue?

I wonder if we really want to translate preset names actually... They are not really explicit anyway 😛

@jlucidar
Copy link
Member

jlucidar commented Jun 1, 2021

Closing this as it was prior to beta release. We will do another localization update round before v1.0.0 release :)

@jlucidar jlucidar closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
BETA version
3 participants
@fichek @jlucidar @Guili123