Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training Stability: Patch HF Hub and Datasets methods and update datasets.py #280

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

farzadab
Copy link
Contributor

We've experienced some issues when training with the basic HF ecosystem. This PR adds some monkey-patches on HF methods (in HF Hub and Datasets) to

  1. alleviates issues like time outs or transient connection errors when downloading data
  2. make datasets more robust to errors like audio field being empty which was not recoverable without patching

As well as some minor cosmetic changes.

@farzadab farzadab requested a review from zqhuang211 February 10, 2025 18:57
@farzadab farzadab changed the title Training Stability: Patch HF Hub and Datasets methods Ultravox v-0.5 Training Update Feb 10, 2025
@farzadab farzadab changed the title Ultravox v-0.5 Training Update Training Stability: Patch HF Hub and Datasets methods Feb 10, 2025
@farzadab farzadab requested review from liPatrick and removed request for liPatrick February 10, 2025 19:23
@farzadab farzadab changed the title Training Stability: Patch HF Hub and Datasets methods Training Stability: Patch HF Hub and Datasets methods and update datasets.py Feb 10, 2025
Copy link
Contributor

@zqhuang211 zqhuang211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farzadab farzadab merged commit 5a50e8e into main Feb 11, 2025
1 check passed
@farzadab farzadab deleted the farzad-patch-hf branch February 11, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants