Rollup of stale PRs #4607
Merged
Rollup of stale PRs #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
==========================================
- Coverage 82.14% 82.14% -0.01%
==========================================
Files 255 255
Lines 31283 31282 -1
==========================================
- Hits 25698 25697 -1
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Resolve a TODO for logging the address of a descriptor chain head if fetching it from guest memory fails. Closes firecracker-microvm#3592 Co-Authored-By: sladynnunes <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
Resolve a TODO about documenting a panic condition. Closes firecracker-microvm#3636 Co-Authored-by: Landon Johnson <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
The name is fine. When it was tried to be changed in firecracker-microvm#3636 we could not come up with anything better really. Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
pb8o
previously approved these changes
May 13, 2024
ShadowCurse
previously approved these changes
May 13, 2024
pb8o
approved these changes
May 13, 2024
ShadowCurse
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolve 3 TODOs in the codebase
Reason
Rollup seemingly abandoned PRs that we still think have value to be merged.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.