Skip to content

Commit

Permalink
Remove TODO about renaming app_metrics field/parameter
Browse files Browse the repository at this point in the history
The name is fine. When it was tried to be changed in #3636 we could not
come up with anything better really.

Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed May 8, 2024
1 parent c60aed6 commit 05f7195
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/vmm/src/logger/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ pub struct Metrics<T: Serialize, M: Write + Send> {

impl<T: Serialize + Debug, M: Write + Send + Debug> Metrics<T, M> {
/// Creates a new instance of the current metrics.
// TODO: We need a better name than app_metrics (something that says that these are the actual
// values that we are writing to the metrics_buf).
pub const fn new(app_metrics: T) -> Metrics<T, M> {
Metrics {
metrics_buf: OnceLock::new(),
Expand Down

0 comments on commit 05f7195

Please sign in to comment.