Skip to content

Fix the rest of flaky windows tests. #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvansch1 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −8
Open

Fix the rest of flaky windows tests. #2124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcc4376
Actually run the ParamSpec location test on windows. (#2122)
Jan 15, 2026
d4beda4
Fix the rest of flaky windows tests.
Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pyrefly/lib/test/lsp/lsp_interaction/inlay_hint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,6 @@ fn test_inlay_hint_typevar_has_location() {
interaction.shutdown().unwrap();
}

/// TODO(jvansch): Figure out why this is timing out on Windows
#[cfg(not(windows))]
#[test]
fn test_inlay_hint_typevartuple_has_location() {
let root = get_test_files_root();
Expand Down Expand Up @@ -515,8 +513,6 @@ fn test_inlay_hint_typevartuple_has_location() {
interaction.shutdown().unwrap();
}

/// TODO(jvansch): Figure out why this is timing out on Windows
#[cfg(not(windows))]
#[test]
fn test_inlay_hint_paramspec_has_location() {
let root = get_test_files_root();
Expand Down Expand Up @@ -643,8 +639,6 @@ fn test_inlay_hint_anonymous_typed_dict_has_location() {
interaction.shutdown().unwrap();
}

// TODO(jvansch): re-enable on windows
#[cfg(not(windows))]
#[test]
fn test_inlay_hint_literal_string_has_location() {
let root = get_test_files_root();
Expand Down
2 changes: 1 addition & 1 deletion pyrefly/lib/test/lsp/lsp_interaction/test_files/literal_string_inlay_hint_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

from typing import LiteralString
from typing_extensions import LiteralString


def get_literal_string(x: LiteralString):
Expand Down
2 changes: 1 addition & 1 deletion pyrefly/lib/test/lsp/lsp_interaction/test_files/typevartuple_inlay_hint_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

from typing import TypeVarTuple
from typing_extensions import TypeVarTuple

Ts = TypeVarTuple("Ts")

Expand Down
Loading