Fix the rest of flaky windows tests. #2124
Open
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2026 12:42
Summary: A previous test update the diff but never actually allowed the test to run in a windows environment. Differential Revision: D90793146
Summary: For LiteralString and TypeVarTuple tests, make sure we also import it from typing_extensions so the test is not version dependent. Differential Revision: D90796722
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
rchen152
approved these changes
Jan 15, 2026
Contributor
rchen152
left a comment
rchen152
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For LiteralString and TypeVarTuple tests, make sure we also import it from typing_extensions so the test is not version dependent.
Differential Revision: D90796722